Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove unused workers.persistence.containerLifecycleHooks field#60239

Merged
jscheffl merged 1 commit intoapache:mainfrom
Miretpl:remove-unused-persistence-field
Jan 7, 2026
Merged

Remove unused workers.persistence.containerLifecycleHooks field#60239
jscheffl merged 1 commit intoapache:mainfrom
Miretpl:remove-unused-persistence-field

Conversation

Copy link
Contributor

Miretpl commented Jan 7, 2026

While working on #60238, I noticed that workers.persistence.containerLifecycleHooks is not used anywhere in the chart. It was added in #32349, probably by mistake (different persistence sections do not have it).


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

Miretpl requested review from hussein-awala, jedcunningham and jscheffl as code owners January 7, 2026 20:29
boring-cyborg bot added the area:helm-chart Airflow Helm Chart label Jan 7, 2026
jscheffl approved these changes Jan 7, 2026
jscheffl added this to the Airflow Helm Chart 1.19.0 milestone Jan 7, 2026
jscheffl merged commit 6e93a46 into apache:main Jan 7, 2026
95 checks passed
Miretpl deleted the remove-unused-persistence-field branch January 7, 2026 21:26
chirodip98 pushed a commit to chirodip98/airflow-contrib that referenced this pull request Jan 9, 2026
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
jedcunningham mentioned this pull request Jan 30, 2026
98 tasks
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jscheffl jscheffl approved these changes

jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

Assignees

No one assigned

Labels

area:helm-chart Airflow Helm Chart

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants