-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Fix signal handling in triggerer job runner#60190
Merged
potiuk merged 1 commit intoapache:mainfrom Jan 7, 2026
Merged
Conversation
Member
We were not registering our signal handler in the triggerer job. This meant our logging, to improve visibility into the shutdown process, was missing.
Before:
2026-01-06T22:23:41.797530Z [info ] Starting the triggerer [airflow.jobs.triggerer_job_runner.TriggererJobRunner] loc=triggerer_job_runner.py:166
^C2026-01-06T22:23:42.811630Z [info ] Waiting for triggers to clean up [airflow.jobs.triggerer_job_runner.TriggererJobRunner] loc=triggerer_job_runner.py:183
2026-01-06T22:23:42.817552Z [info ] Process exited [supervisor] exit_code=-2 loc=supervisor.py:716 pid=5187 signal_sent=SIGINT
2026-01-06T22:23:42.818042Z [info ] Exited trigger loop [airflow.jobs.triggerer_job_runner.TriggererJobRunner] loc=triggerer_job_runner.py:188
After:
2026-01-06T22:24:12.663026Z [info ] Starting the triggerer [airflow.jobs.triggerer_job_runner.TriggererJobRunner] loc=triggerer_job_runner.py:166
^C2026-01-06T22:24:20.586689Z [info ] Exiting gracefully upon receiving signal 2 [airflow.jobs.triggerer_job_runner.TriggererJobRunner] loc=triggerer_job_runner.py:157
2026-01-06T22:24:20.718223Z [info ] Waiting for triggers to clean up [airflow.jobs.triggerer_job_runner.TriggererJobRunner] loc=triggerer_job_runner.py:184
2026-01-06T22:24:20.718660Z [info ] Process exited [supervisor] exit_code=0 loc=supervisor.py:716 pid=6382 signal_sent=SIGINT
2026-01-06T22:24:20.718819Z [info ] Exited trigger loop [airflow.jobs.triggerer_job_runner.TriggererJobRunner] loc=triggerer_job_runner.py:189
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
meant our logging, to improve visibility into the shutdown process, was
missing.
jedcunningham
requested review from
dstandish and
hussein-awala
as code owners
January 6, 2026 22:28
potiuk
approved these changes
Jan 6, 2026
jason810496
added
the
backport-to-v3-1-test
Mark PR with this label to backport to v3-1-test branch
label
Jan 7, 2026
jason810496
approved these changes
Jan 7, 2026
amoghrajesh
approved these changes
Jan 7, 2026
ashb
reviewed
Jan 7, 2026
Member
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is running async loop we souls use that for signal handling, not the sync version
https://docs.python.org/3/library/asyncio-eventloop.html#unix-signals
uranusjr
approved these changes
Jan 7, 2026
Member
uranusjr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, although I wonder if there's a better way to manage these instead of have register calls in (seemingly) random places.
Member
|
Using |
hussein-awala
approved these changes
Jan 7, 2026
potiuk
approved these changes
Jan 7, 2026
github-actions bot
pushed a commit
that referenced
this pull request
Jan 7, 2026
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
(cherry picked from commit ee163cd)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
meant our logging, to improve visibility into the shutdown process, was
missing.
(cherry picked from commit ee163cd)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
potiuk
pushed a commit
that referenced
this pull request
Jan 7, 2026
)
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
(cherry picked from commit ee163cd)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
(cherry picked from commit ee163cd)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
chirodip98
pushed a commit
to chirodip98/airflow-contrib
that referenced
this pull request
Jan 9, 2026
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
meant our logging, to improve visibility into the shutdown process, was
missing.
stegololz
pushed a commit
to stegololz/airflow
that referenced
this pull request
Jan 9, 2026
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
meant our logging, to improve visibility into the shutdown process, was
missing.
jhgoebbert
pushed a commit
to jhgoebbert/airflow_Owen-CH-Leung
that referenced
this pull request
Feb 8, 2026
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
meant our logging, to improve visibility into the shutdown process, was
missing.
Subham-KRLX
pushed a commit
to Subham-KRLX/airflow
that referenced
this pull request
Mar 4, 2026
We were not registering our signal handler in the triggerer job. This
meant our logging, to improve visibility into the shutdown process, was
missing.
meant our logging, to improve visibility into the shutdown process, was
missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.