Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Cleanup of variables in settings.py#59875

Merged
jscheffl merged 2 commits intoapache:mainfrom
jscheffl:bugfix/variable-cleanup-in-settings-py
Dec 29, 2025
Merged

Cleanup of variables in settings.py#59875
jscheffl merged 2 commits intoapache:mainfrom
jscheffl:bugfix/variable-cleanup-in-settings-py

Conversation

Copy link
Contributor

jscheffl commented Dec 28, 2025

As I was starting to clean further global variables in settings.py I noticed a couple of constants being defined here which are only used at one place in the codebase. In order to un-clutter the settings.py this PR proposes to remove some fields which in my view are just "lurking" around in the wrong place.

potiuk reviewed Dec 28, 2025
Copy link
Member

potiuk commented Dec 28, 2025

Love it - that might really help with getting rid of the circular dependencies we have :)

jscheffl force-pushed the bugfix/variable-cleanup-in-settings-py branch from b869fec to f548ecb Compare December 28, 2025 20:39
jscheffl added the full tests needed We need to run full set of tests for this PR to merge label Dec 28, 2025
jscheffl marked this pull request as ready for review December 28, 2025 21:47
jscheffl added the all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs label Dec 28, 2025
Copy link
Contributor Author

jscheffl commented Dec 28, 2025

Force restart CI

jscheffl closed this Dec 28, 2025
jscheffl reopened this Dec 28, 2025
jscheffl requested a review from potiuk December 28, 2025 22:55
potiuk approved these changes Dec 29, 2025
potiuk force-pushed the bugfix/variable-cleanup-in-settings-py branch from f548ecb to 7ba0abe Compare December 29, 2025 10:13
jscheffl merged commit b7e909f into apache:main Dec 29, 2025
209 checks passed
shahar1 mentioned this pull request Dec 30, 2025
54 tasks
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Jan 2, 2026
* Cleanup of variables in settings.py

* Fix pytest mocks
stegololz pushed a commit to stegololz/airflow that referenced this pull request Jan 9, 2026
* Cleanup of variables in settings.py

* Fix pytest mocks
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
* Cleanup of variables in settings.py

* Fix pytest mocks
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
* Cleanup of variables in settings.py

* Fix pytest mocks
Ankurdeewan pushed a commit to Ankurdeewan/airflow that referenced this pull request Mar 15, 2026
* Cleanup of variables in settings.py

* Fix pytest mocks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

potiuk potiuk approved these changes

ashb Awaiting requested review from ashb ashb is a code owner

amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

rawwar Awaiting requested review from rawwar rawwar is a code owner

jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees

No one assigned

Labels

all versions If set, the CI build will be forced to use all versions of Python/K8S/DBs area:API Airflow's REST/HTTP API area:CLI area:DAG-processing area:db-migrations PRs with DB migration area:logging area:providers area:Scheduler including HA (high availability) scheduler area:serialization full tests needed We need to run full set of tests for this PR to merge kind:documentation provider:apache-spark provider:celery

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants