-
Notifications
You must be signed in to change notification settings - Fork 16.6k
[v3-1-test] Fix import errors not cleared for files without DAGs (#58242)#59500
Merged
ephraimbuddy merged 1 commit intov3-1-testfrom Dec 16, 2025
Merged
[v3-1-test] Fix import errors not cleared for files without DAGs (#58242)#59500ephraimbuddy merged 1 commit intov3-1-testfrom
ephraimbuddy merged 1 commit intov3-1-testfrom
Conversation
Contributor
- Fix import errors not cleared for files without DAGs
Previously, import errors persisted in the database for files that were successfully parsed but no longer contained any DAGs. This happened because we only tracked files that had DAGs, missing files that were parsed successfully but had their DAGs removed.
Now, when files are parsed, all parsed files are tracked (not just those with DAGs), ensuring import errors are properly cleared when a file is successfully parsed without errors, even if it no longer contains DAGs.
closes: #57621
-
Apply suggestions from code review
-
fixup! Fix import errors not cleared for files without DAGs
-
Remove fallback for files_parsed
-
fixup! fixup! Fix import errors not cleared for files without DAGs
-
fixup! Remove fallback for files_parsed
-
fixup! fixup! fixup! Fix import errors not cleared for files without DAGs
(cherry picked from commit 796b46e)
)
* Fix import errors not cleared for files without DAGs
Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.
Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.
closes: #57621
* Apply suggestions from code review
Co-authored-by: Tzu-ping Chung
* fixup! Fix import errors not cleared for files without DAGs
* Remove fallback for files_parsed
* fixup! fixup! Fix import errors not cleared for files without DAGs
* fixup! Remove fallback for files_parsed
* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs
---------
(cherry picked from commit 796b46e)
Co-authored-by: Ephraim Anierobi
Co-authored-by: Tzu-ping Chung
* Fix import errors not cleared for files without DAGs
Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.
Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.
closes: #57621
* Apply suggestions from code review
Co-authored-by: Tzu-ping Chung
* fixup! Fix import errors not cleared for files without DAGs
* Remove fallback for files_parsed
* fixup! fixup! Fix import errors not cleared for files without DAGs
* fixup! Remove fallback for files_parsed
* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs
---------
(cherry picked from commit 796b46e)
Co-authored-by: Ephraim Anierobi
Co-authored-by: Tzu-ping Chung
ephraimbuddy
requested review from
XD-DENG,
ashb and
jedcunningham
as code owners
December 16, 2025 09:54
ephraimbuddy
added a commit
that referenced
this pull request
Jan 6, 2026
) (#59500)
* Fix import errors not cleared for files without DAGs
Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.
Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.
closes: #57621
* Apply suggestions from code review
* fixup! Fix import errors not cleared for files without DAGs
* Remove fallback for files_parsed
* fixup! fixup! Fix import errors not cleared for files without DAGs
* fixup! Remove fallback for files_parsed
* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs
---------
(cherry picked from commit 796b46e)
Co-authored-by: Tzu-ping Chung
* Fix import errors not cleared for files without DAGs
Previously, import errors persisted in the database for files that were
successfully parsed but no longer contained any DAGs. This happened
because we only tracked files that had DAGs, missing files that
were parsed successfully but had their DAGs removed.
Now, when files are parsed, all parsed files are tracked (not just those
with DAGs), ensuring import errors are properly cleared when a file is
successfully parsed without errors, even if it no longer contains DAGs.
closes: #57621
* Apply suggestions from code review
* fixup! Fix import errors not cleared for files without DAGs
* Remove fallback for files_parsed
* fixup! fixup! Fix import errors not cleared for files without DAGs
* fixup! Remove fallback for files_parsed
* fixup! fixup! fixup! Fix import errors not cleared for files without DAGs
---------
(cherry picked from commit 796b46e)
Co-authored-by: Tzu-ping Chung
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.