Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Adding Japanese translations for UI (i18n)#59313

Merged
potiuk merged 2 commits intoapache:mainfrom
rsanda:add-jp-translation
Dec 14, 2025
Merged

Adding Japanese translations for UI (i18n)#59313
potiuk merged 2 commits intoapache:mainfrom
rsanda:add-jp-translation

Conversation

Copy link
Contributor

rsanda commented Dec 11, 2025

This PR contains the translations for Japanese as proposed in the following mail.
https://lists.apache.org/thread/wdys3tnfx7vnhv350bwcbcmoc52h3yyd

This is the first time I'm contributing to Airflow. So, if I am doing something wrong, please feel free to point it out.
Looking forward to hearing your feedback!

Best,

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

sekikn, potiuk, and choo121600 reacted with hooray emoji
Copy link

boring-cyborg bot commented Dec 11, 2025

Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
Here are some useful points:

  • Pay attention to the quality of your code (ruff, mypy and type annotations). Our prek-hooks will help you with that.
  • In case of a new feature add useful documentation (in docstrings or in docs/ directory). Adding a new operator? Check this short guide Consider adding an example DAG that shows how users should use it.
  • Consider using Breeze environment for testing locally, it's a heavy docker but it ships with a working Airflow and a lot of integrations.
  • Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
  • Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
  • Be sure to read the Airflow Coding style.
  • Always keep your Pull Requests rebased, otherwise your build might fail due to changes not related to your commits.
    Apache Airflow is a community-driven project and together we are making it better .
    In case of doubts contact the developers at:
    Mailing List: dev@airflow.apache.org
    Slack: https://s.apache.org/airflow-slack

boring-cyborg bot added area:dev-tools area:translations area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Dec 11, 2025
potiuk approved these changes Dec 11, 2025
Copy link
Member

potiuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wooohoooe

Copy link
Member

potiuk commented Dec 11, 2025

Technical approval - but would be great for people who speak Japanese to review: @sekikn Maybe :)
sekikn reacted with thumbs up emoji

potiuk reviewed Dec 11, 2025
Copy link
Member

choo121600 commented Dec 11, 2025 *
edited
Loading

WOW, it's great to see a neighboring country language being added

You can add and remove keys using a command like this
breeze ui check-translation-completeness --language ja --add-missing --remove-extra
potiuk, sekikn, Lee-W, and rsanda reacted with thumbs up emoji

potiuk force-pushed the add-jp-translation branch from 896e247 to 37827bb Compare December 11, 2025 22:08
jscheffl reviewed Dec 11, 2025
Copy link
Contributor

jscheffl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the small gaps looks very good. But to further maintain we should also adjust the .github/CODEOWNERS and describe who would be sponsor as committer and who would be engaged translator. Can you add this? Would you volunteer yourself to be the engaged translator?

Can Nian nagaraRi Ben Yu haHua semasenga, GoogleFan Yi woShi tsuteFan Yi woShi shiteimasu. Xiao sanaQian Luo woChu keba, Fei Chang niLiang sasoudesu. shikashi, saranimentenansuwoXing utameniha, .github/CODEOWNERS woBian Ji shi, Shui gakomitsuta-toshitesuponsa-tonari, Shui gaFan Yi Zhe toshiteGuan Yu surukawoJi Zai suruBi Yao gaarimasu. konoQing Bao woZhui Jia shiteitadakemasuka?goZi Shen deFan Yi Zhe toshiteGuan Yu shiteitadakemasuka?

sekikn and rsanda reacted with thumbs up emoji
Copy link
Contributor

sekikn commented Dec 11, 2025 *
edited
Loading

Thank you for the review and advice everyone! Regarding .github/CODEOWNERS, @uranusjr, @rsanda, and I will be involved as the translation sponsor, engaged translator, and translation owner respectively. Would you address the comments above @rsanda?
rsanda reacted with thumbs up emoji

Copy link
Contributor Author

rsanda commented Dec 11, 2025

Thank you all.
Will add the responsible persons to the file and ping you all.

Thanks again.
potiuk, sekikn, and choo121600 reacted with rocket emoji

Lee-W reviewed Dec 12, 2025
Copy link
Member

pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to update the CODEOWNERS file. (translation owners + sponsors)

Code looks good.

Can't vouch for the translation

rsanda reacted with thumbs up emoji
...ranslations, removed extra translations, and not keeping Providers as it is (in English).
rsanda force-pushed the add-jp-translation branch from 37827bb to 8231440 Compare December 13, 2025 14:24
Copy link
Contributor Author

rsanda commented Dec 13, 2025 *
edited
Loading

Thanks a lot for the feedback.
I have updated the code with all the comments.

  • Added codeowners
  • Removed extra translations and added missing ones as breeze result suggested
  • Didn't translate "Providers" in "ja/admin.json" following the example of other languages.
choo121600 reacted with rocket emoji

choo121600 reviewed Dec 14, 2025
Copy link
Member

choo121600 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gooood

potiuk reacted with thumbs up emoji
potiuk approved these changes Dec 14, 2025
Copy link
Member

potiuk commented Dec 14, 2025

All important tests passed :). Merging. Congrats on 100% completion of Japanese :D WOOOHOOO!!!!

rsanda and sekikn reacted with heart emoji

Copy link
Member

potiuk commented Dec 14, 2025

The failing tests is fixed in main already.

potiuk merged commit 93454f0 into apache:main Dec 14, 2025
117 of 120 checks passed
Copy link

boring-cyborg bot commented Dec 14, 2025

Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions.

Copy link

github-actions bot commented Dec 14, 2025

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test

You can attempt to backport this manually by running:

cherry_picker 93454f0 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

Copy link
Member

potiuk commented Dec 14, 2025

No backporting needed .

Copy link
Member

potiuk commented Dec 14, 2025

Just to Add - No backporting needed - unless you would like to contribute it to v3-1-test -> some small changes will be needed as set of features is abit different in v3-1-test @rsanda . You could open a new pr wiht those changes towards v3-1-test and submit it there - I do not think anyone will have anythoing against adding Japanese in 3.1.6
rsanda and sekikn reacted with thumbs up emoji rsanda reacted with heart emoji

rsanda mentioned this pull request Dec 17, 2025
potiuk added this to the Airflow 3.1.6 milestone Dec 17, 2025
TempestShaw pushed a commit to TempestShaw/airflow that referenced this pull request Dec 24, 2025
* Adding Japanese translations for UI

* Response to comments on PR#59313. Updated CODEOWNERS, added missing translations, removed extra translations, and not keeping Providers as it is (in English).
ephraimbuddy removed this from the Airflow 3.1.6 milestone Jan 7, 2026
jhgoebbert pushed a commit to jhgoebbert/airflow_Owen-CH-Leung that referenced this pull request Feb 8, 2026
* Adding Japanese translations for UI

* Response to comments on PR#59313. Updated CODEOWNERS, added missing translations, removed extra translations, and not keeping Providers as it is (in English).
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
* Adding Japanese translations for UI

* Response to comments on PR#59313. Updated CODEOWNERS, added missing translations, removed extra translations, and not keeping Providers as it is (in English).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Lee-W Lee-W left review comments

pierrejeambrun pierrejeambrun left review comments

choo121600 choo121600 left review comments

jscheffl jscheffl left review comments

potiuk potiuk approved these changes

ashb Awaiting requested review from ashb ashb is a code owner

gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

kaxil Awaiting requested review from kaxil

jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

guan404ming Awaiting requested review from guan404ming guan404ming is a code owner

Assignees

No one assigned

Labels

area:dev-tools area:translations area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants