Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix airflowignore negation does not work in subfolders#58740

Merged
potiuk merged 3 commits intoapache:mainfrom
henry3260:fix-airflowignore
Nov 29, 2025
Merged

fix airflowignore negation does not work in subfolders#58740
potiuk merged 3 commits intoapache:mainfrom
henry3260:fix-airflowignore

Conversation

Copy link
Contributor

henry3260 commented Nov 26, 2025 *
edited
Loading

Closes: #58636
From docs;
https://airflow.apache.org/docs/apache-airflow/stable/core-concepts/dags.html#airflowignore
https://git-scm.com/docs/gitignore


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

henry3260 mentioned this pull request Nov 26, 2025
Lee-W reviewed Nov 27, 2025
Copy link
Member

Lee-W commented Nov 28, 2025

Thanks, but we'll need to resolve the CI failure before the next round review

henry3260 force-pushed the fix-airflowignore branch 2 times, most recently from 9008e27 to d7d836f Compare November 28, 2025 21:06
potiuk approved these changes Nov 28, 2025
Copy link
Member

potiuk commented Nov 28, 2025

Thanks, but we'll need to resolve the CI failure before the next round review

Yep.

Lee-W reacted with thumbs up emoji

henry3260 force-pushed the fix-airflowignore branch from d7d836f to 1566104 Compare November 29, 2025 06:17
henry3260 force-pushed the fix-airflowignore branch from 1566104 to 2f4ec69 Compare November 29, 2025 07:14
henry3260 requested a review from Lee-W November 29, 2025 19:15
potiuk approved these changes Nov 29, 2025
potiuk merged commit 33cb64a into apache:main Nov 29, 2025
118 checks passed
henry3260 deleted the fix-airflowignore branch November 30, 2025 05:41
RoyLee1224 pushed a commit to RoyLee1224/airflow that referenced this pull request Dec 3, 2025
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Copy link

devgonvarun commented Dec 11, 2025 *
edited
Loading

Hi @henry3260, in which airflow version will this be released? Noticed that this is merged with main but not part of the recent airflow 3.1.4 release.

Lee-W pushed a commit to astronomer/airflow that referenced this pull request Dec 11, 2025
...pache#58740)

(cherry picked from commit 33cb64a)

Co-authored-by: Henry Chen <108824346+henry3260@users.noreply.github.com>
Copy link
Member

Lee-W commented Dec 11, 2025

Hi @henry3260, in which airflow version will this be released? Noticed that this is merged with main but not part of the recent airflow 3.1.4 release.

We miss backporting it. I just did #59305. most likely 3.1.5

potiuk reacted with thumbs up emoji

potiuk added this to the Airflow 3.1.5 milestone Dec 11, 2025
Lee-W added a commit that referenced this pull request Dec 11, 2025
...58740) (#59305)

Co-authored-by: Henry Chen <108824346+henry3260@users.noreply.github.com>
ephraimbuddy pushed a commit that referenced this pull request Dec 12, 2025
...58740) (#59305)

Co-authored-by: Henry Chen <108824346+henry3260@users.noreply.github.com>
Copy link

devgonvarun commented Dec 15, 2025

Hi @Lee-W, I dont see this in the airflow 3.1.5 source code despite the milestone set as 3.1.5.

Lee-W modified the milestones: Airflow 3.1.5, Airflow 3.1.6 Dec 16, 2025
Copy link
Member

Lee-W commented Dec 16, 2025

Hi @Lee-W, I dont see this in the airflow 3.1.5 source code despite the milestone set as 3.1.5.

3.1.4 was yanked due to an accidental release mistake, and 3.1.5 is essentially 3.1.4rc2. Thus, we did not add anything to 3.1.5 / 3.1.4rc2. This will be added to 3.1.6 instead

ephraimbuddy pushed a commit that referenced this pull request Jan 6, 2026
...58740) (#59305)

Co-authored-by: Henry Chen <108824346+henry3260@users.noreply.github.com>
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

potiuk potiuk approved these changes

Lee-W Awaiting requested review from Lee-W

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Airflow 3.1.6

Development

Successfully merging this pull request may close these issues.

airflowignore negation does not work in subfolders

4 participants