Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix for object rendering in HITL interface#58611

Merged
bbovenzi merged 1 commit intoapache:mainfrom
stuart23:stuart23-fix-hitl-object-rendering
Nov 25, 2025
Merged

Fix for object rendering in HITL interface#58611
bbovenzi merged 1 commit intoapache:mainfrom
stuart23:stuart23-fix-hitl-object-rendering

Conversation

Copy link
Contributor

stuart23 commented Nov 24, 2025

HITL Approve UI does not correctly display object DAG parameters. These were being displayed as [object Object] (see below).

Main change (hitl.ts):

  • Added support for preloading parameter values from URL query strings
  • Added JSON parsing for string values that look like JSON objects
  • Fixed type detection to correctly identify object parameters (instead of defaulting to string)
    Test file (hitl.test.ts):
  • New test verifying object parameters are typed as 'object'

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

stuart23 requested review from bbovenzi, guan404ming, pierrejeambrun, ryanahamilton and shubhamraj-git as code owners November 24, 2025 09:29
boring-cyborg bot added the area:UI Related to UI/UX. For Frontend Developers. label Nov 24, 2025
seanghaeli approved these changes Nov 24, 2025
bbovenzi added this to the Airflow 3.1.4 milestone Nov 25, 2025
bbovenzi added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Nov 25, 2025
bbovenzi approved these changes Nov 25, 2025
Copy link
Contributor

bbovenzi commented Nov 25, 2025

Thanks for adding a test too!

bbovenzi merged commit caab2a9 into apache:main Nov 25, 2025
62 checks passed
Copy link

github-actions bot commented Nov 25, 2025

Backport failed to create: v3-1-test. View the failure log Run details

Status Branch Result
v3-1-test

You can attempt to backport this manually by running:

cherry_picker caab2a9 v3-1-test

This should apply the commit to the v3-1-test branch and leave the commit in conflict state marking
the files that need manual conflict resolution.

After you have resolved the conflicts, you can continue the backport process by running:

cherry_picker --continue

Copy link
Contributor Author

stuart23 commented Nov 26, 2025

Thanks for adding a test too!

You know I always do!

stuart23 deleted the stuart23-fix-hitl-object-rendering branch November 26, 2025 02:58
ephraimbuddy added the type:bug-fix Changelog: Bug Fixes label Dec 1, 2025
ephraimbuddy pushed a commit that referenced this pull request Dec 2, 2025
ephraimbuddy pushed a commit that referenced this pull request Dec 3, 2025
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

bbovenzi bbovenzi approved these changes

pierrejeambrun Awaiting requested review from pierrejeambrun pierrejeambrun is a code owner

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

guan404ming Awaiting requested review from guan404ming guan404ming is a code owner

+1 more reviewer

seanghaeli seanghaeli approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch type:bug-fix Changelog: Bug Fixes

Projects

None yet

Milestone

Airflow 3.1.4

Development

Successfully merging this pull request may close these issues.

4 participants