-
Notifications
You must be signed in to change notification settings - Fork 16.6k
[v3-1-test] Fix db cleanup logging behavior and docstrings (#58459)#58523
Merged
ephraimbuddy merged 1 commit intov3-1-testfrom Nov 20, 2025
Merged
[v3-1-test] Fix db cleanup logging behavior and docstrings (#58459)#58523ephraimbuddy merged 1 commit intov3-1-testfrom
ephraimbuddy merged 1 commit intov3-1-testfrom
Conversation
Update _check_for_rows to avoid unnecessary logging and
queries when there are no rows, fix a typo in run_cleanup docstring, and correct _suppress_with_logging docstring.
(cherry picked from commit 1f6f868)
Co-authored-by: Jed Cunningham 66968678+jedcunningham@users.noreply.github.com
Co-authored-by: Ian Buss ianbuss@users.noreply.github.com
Update `_check_for_rows` to avoid unnecessary logging and
queries when there are no rows, fix a typo in `run_cleanup
docstring`, and correct `_suppress_with_logging` docstring.
(cherry picked from commit 1f6f868)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Ian Buss
queries when there are no rows, fix a typo in `run_cleanup
docstring`, and correct `_suppress_with_logging` docstring.
(cherry picked from commit 1f6f868)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Ian Buss
ephraimbuddy
pushed a commit
that referenced
this pull request
Nov 20, 2025
...58523)
Update `_check_for_rows` to avoid unnecessary logging and
queries when there are no rows, fix a typo in `run_cleanup
docstring`, and correct `_suppress_with_logging` docstring.
(cherry picked from commit 1f6f868)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Ian Buss
Update `_check_for_rows` to avoid unnecessary logging and
queries when there are no rows, fix a typo in `run_cleanup
docstring`, and correct `_suppress_with_logging` docstring.
(cherry picked from commit 1f6f868)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Ian Buss
ephraimbuddy
added
type:bug-fix
Changelog: Bug Fixes
type:doc-only
Changelog: Doc Only
labels
Dec 1, 2025
ephraimbuddy
pushed a commit
that referenced
this pull request
Dec 3, 2025
...58523)
Update `_check_for_rows` to avoid unnecessary logging and
queries when there are no rows, fix a typo in `run_cleanup
docstring`, and correct `_suppress_with_logging` docstring.
(cherry picked from commit 1f6f868)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Ian Buss
Update `_check_for_rows` to avoid unnecessary logging and
queries when there are no rows, fix a typo in `run_cleanup
docstring`, and correct `_suppress_with_logging` docstring.
(cherry picked from commit 1f6f868)
Co-authored-by: Jed Cunningham <66968678+jedcunningham@users.noreply.github.com>
Co-authored-by: Ian Buss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.