Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[v3-1-test] Fix systemd service files issues (#57126)#57231

Merged
potiuk merged 1 commit intov3-1-testfrom
backport-b370160-v3-1-test
Oct 25, 2025
Merged

[v3-1-test] Fix systemd service files issues (#57126)#57231
potiuk merged 1 commit intov3-1-testfrom
backport-b370160-v3-1-test

Conversation

Copy link

github-actions bot commented Oct 25, 2025

This commit addresses multiple bugs in systemd service files reported
in issue #53706:

  1. Fix incorrect command in airflow-api.service

    • Changed 'airflow api' to 'airflow api-server' (correct CLI command)
  2. Standardize environment configuration approach

    • Changed airflow-api.service and airflow-triggerer.service to use
      EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment
    • This provides consistency with other services and allows admins
      flexibility to manage custom environment variables centrally
  3. Fix service dependencies

    • Added proper After= and Wants= clauses for database and message
      queue services (postgresql, mysql, redis, rabbitmq) to
      airflow-api.service and airflow-triggerer.service
    • Services now wait for required dependencies before starting
  4. Additional bug fixes discovered during review

    • airflow-flower.service: Removed duplicate ExecStart line
    • airflow-kerberos.service: Fixed command from 'kerberos' to
      'airflow kerberos'
  5. Consistency improvements

    • Added Type=simple and RestartSec=5s to airflow-api.service and
      airflow-triggerer.service for consistency with other services

All systemd service files now follow the same configuration pattern,
making them easier to maintain and more reliable during system startup.

Fixes #53706
(cherry picked from commit b370160)

Co-authored-by: Ashir Alam alamashir@gmail.com

This commit addresses multiple bugs in systemd service files reported
in issue #53706:

1. Fix incorrect command in airflow-api.service
- Changed 'airflow api' to 'airflow api-server' (correct CLI command)

2. Standardize environment configuration approach
- Changed airflow-api.service and airflow-triggerer.service to use
EnvironmentFile=/etc/sysconfig/airflow instead of inline Environment
- This provides consistency with other services and allows admins
flexibility to manage custom environment variables centrally

3. Fix service dependencies
- Added proper After= and Wants= clauses for database and message
queue services (postgresql, mysql, redis, rabbitmq) to
airflow-api.service and airflow-triggerer.service
- Services now wait for required dependencies before starting

4. Additional bug fixes discovered during review
- airflow-flower.service: Removed duplicate ExecStart line
- airflow-kerberos.service: Fixed command from 'kerberos' to
'airflow kerberos'

5. Consistency improvements
- Added Type=simple and RestartSec=5s to airflow-api.service and
airflow-triggerer.service for consistency with other services

All systemd service files now follow the same configuration pattern,
making them easier to maintain and more reliable during system startup.

Fixes #53706
(cherry picked from commit b370160)

Co-authored-by: Ashir Alam
github-actions bot mentioned this pull request Oct 25, 2025
boring-cyborg bot added area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch labels Oct 25, 2025
potiuk marked this pull request as ready for review October 25, 2025 16:53
potiuk requested review from amoghrajesh, ashb, bugraoz93, eladkal, gopidesupavan, jason810496, jscheffl, kaxil and potiuk as code owners October 25, 2025 16:53
potiuk merged commit 51ff37d into v3-1-test Oct 25, 2025
4 checks passed
potiuk deleted the backport-b370160-v3-1-test branch October 25, 2025 16:53
potiuk mentioned this pull request Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

potiuk Awaiting requested review from potiuk potiuk is a code owner

ashb Awaiting requested review from ashb ashb is a code owner

gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

jscheffl Awaiting requested review from jscheffl jscheffl is a code owner

bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

kaxil Awaiting requested review from kaxil kaxil is a code owner

eladkal Awaiting requested review from eladkal eladkal is a code owner

jason810496 Awaiting requested review from jason810496 jason810496 is a code owner

Assignees

No one assigned

Labels

area:dev-tools backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants