Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add team_id to variable APIs#57102

Merged
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:vincbeck/variable_api_team
Nov 24, 2025
Merged

Add team_id to variable APIs#57102
vincbeck merged 1 commit intoapache:mainfrom
aws-mwaa:vincbeck/variable_api_team

Conversation

Copy link
Contributor

vincbeck commented Oct 22, 2025 *
edited
Loading

Add team_id to public variable APIs. When a user create a variable through the public API, they need to specify the team (if any) it belongs to.

On task SDK/execution API side, the team should not be provided by the user (dag author in this context) but it should be inferred from the Dag. This change will be done in a separate PR. In this same future PR I'll also add authorization so that a variable that belongs to teamA cannot be retrieved from a Dag that belongs to teamB.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

vincbeck requested review from o-nikolas and potiuk October 22, 2025 20:37
boring-cyborg bot added area:airflow-ctl area:API Airflow's REST/HTTP API area:DAG-processing area:task-sdk area:UI Related to UI/UX. For Frontend Developers. labels Oct 22, 2025
vincbeck force-pushed the vincbeck/variable_api_team branch 2 times, most recently from b49a16c to a41aae7 Compare October 23, 2025 15:55
vincbeck force-pushed the vincbeck/variable_api_team branch from a41aae7 to 7a65964 Compare October 30, 2025 16:31
vincbeck force-pushed the vincbeck/variable_api_team branch 5 times, most recently from ae1b9bd to ef0b2dd Compare November 7, 2025 18:06
vincbeck marked this pull request as ready for review November 7, 2025 18:06
vincbeck force-pushed the vincbeck/variable_api_team branch from ef0b2dd to fc4edc9 Compare November 7, 2025 19:13
jason810496 approved these changes Nov 8, 2025
Copy link
Member

jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! LGTM overall.

bugraoz93 approved these changes Nov 9, 2025
bbovenzi removed the area:UI Related to UI/UX. For Frontend Developers. label Nov 20, 2025
pierrejeambrun approved these changes Nov 21, 2025
Copy link
Member

pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM beside the comment above

vincbeck force-pushed the vincbeck/variable_api_team branch from fc4edc9 to de054a4 Compare November 24, 2025 16:15
vincbeck force-pushed the vincbeck/variable_api_team branch from de054a4 to f5e7fe9 Compare November 24, 2025 16:17
vincbeck merged commit d53814c into apache:main Nov 24, 2025
118 checks passed
vincbeck deleted the vincbeck/variable_api_team branch November 24, 2025 17:59
Copilot AI pushed a commit to jason810496/airflow that referenced this pull request Dec 5, 2025
itayweb pushed a commit to itayweb/airflow that referenced this pull request Dec 6, 2025
bugraoz93 mentioned this pull request Jan 9, 2026
24 tasks
Subham-KRLX pushed a commit to Subham-KRLX/airflow that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pierrejeambrun pierrejeambrun approved these changes

bugraoz93 bugraoz93 approved these changes

jason810496 jason810496 approved these changes

potiuk Awaiting requested review from potiuk potiuk is a code owner

o-nikolas Awaiting requested review from o-nikolas

ashb Awaiting requested review from ashb ashb is a code owner

kaxil Awaiting requested review from kaxil kaxil is a code owner

amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

guan404ming Awaiting requested review from guan404ming guan404ming is a code owner

ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

rawwar Awaiting requested review from rawwar rawwar is a code owner

XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants