-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Merged
Conversation
Member
Similarly to https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/definitions/taskgroup.py#L561, we need an exit condition if the taskgroup is found in usorted graph.
Adjusted test, which indeed were not in the correct topological order.
Testing dag code:
from __future__ import annotations
import datetime
import pendulum
from airflow.sdk import dag, task, task_group
@task
def get_nums() -> list[int]:
return [1, 2, 4]
@task
def times_2(n: int) -> int:
return n * 2
@task_group(group_id="process_number")
def process_number(n: int):
value = times_2(n)
return value
@task
def log_success() -> None:
print("Processed successful!")
@dag(
schedule=None,
catchup=False,
start_date=pendulum.datetime(2025, 4, 1, tz="Europe/Copenhagen"),
dagrun_timeout=datetime.timedelta(minutes=30),
dag_id="55899_bug",
)
def test():
nums = get_nums()
processed = process_number.expand(n=nums)
processed >> log_success()
test()
import datetime
import pendulum
from airflow.sdk import dag, task, task_group
@task
def get_nums() -> list[int]:
return [1, 2, 4]
@task
def times_2(n: int) -> int:
return n * 2
@task_group(group_id="process_number")
def process_number(n: int):
value = times_2(n)
return value
@task
def log_success() -> None:
print("Processed successful!")
@dag(
schedule=None,
catchup=False,
start_date=pendulum.datetime(2025, 4, 1, tz="Europe/Copenhagen"),
dagrun_timeout=datetime.timedelta(minutes=30),
dag_id="55899_bug",
)
def test():
nums = get_nums()
processed = process_number.expand(n=nums)
processed >> log_success()
test()
Before
After
pierrejeambrun
added
the
backport-to-v3-1-test
Mark PR with this label to backport to v3-1-test branch
label
Oct 21, 2025
Member
|
I tried to fix this in #56321 |
Member
Author
|
Yes, I Think this implementation is simpler and should be favored, also it is more in lined with the sdk implementation |
Member
Author
|
Cc: @kaxil |
kaxil
approved these changes
Oct 21, 2025
dheerajturaga
approved these changes
Oct 21, 2025
Member
Agreed! Thanks for fixing this! |
github-actions bot
pushed a commit
that referenced
this pull request
Oct 21, 2025
Fixes: #55899
Closes #56321
Similarly to https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/definitions/taskgroup.py#L561, we need an exit condition if the taskgroup is found in usorted graph.
Adjusted test, which indeed were not in the correct topological order.
Testing dag code:
```python
from __future__ import annotations
import datetime
import pendulum
from airflow.sdk import dag, task, task_group
@task
def get_nums() -> list[int]:
return [1, 2, 4]
@task
def times_2(n: int) -> int:
return n * 2
@task_group(group_id="process_number")
def process_number(n: int):
value = times_2(n)
return value
@task
def log_success() -> None:
print("Processed successful!")
@dag(
schedule=None,
catchup=False,
start_date=pendulum.datetime(2025, 4, 1, tz="Europe/Copenhagen"),
dagrun_timeout=datetime.timedelta(minutes=30),
dag_id="55899_bug",
)
def test():
nums = get_nums()
processed = process_number.expand(n=nums)
processed >> log_success()
test()
```
### Before
https://github.com/user-attachments/assets/d5220b87-a23b-40f7-8ecf-cb1b39d72f53" />
### After
https://github.com/user-attachments/assets/37f75b19-2e80-4765-b9cb-e425f9054b78" />
(cherry picked from commit c3f53b1)
Co-authored-by: Pierre Jeambrun
Closes #56321
Similarly to https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/definitions/taskgroup.py#L561, we need an exit condition if the taskgroup is found in usorted graph.
Adjusted test, which indeed were not in the correct topological order.
Testing dag code:
```python
from __future__ import annotations
import datetime
import pendulum
from airflow.sdk import dag, task, task_group
@task
def get_nums() -> list[int]:
return [1, 2, 4]
@task
def times_2(n: int) -> int:
return n * 2
@task_group(group_id="process_number")
def process_number(n: int):
value = times_2(n)
return value
@task
def log_success() -> None:
print("Processed successful!")
@dag(
schedule=None,
catchup=False,
start_date=pendulum.datetime(2025, 4, 1, tz="Europe/Copenhagen"),
dagrun_timeout=datetime.timedelta(minutes=30),
dag_id="55899_bug",
)
def test():
nums = get_nums()
processed = process_number.expand(n=nums)
processed >> log_success()
test()
```
### Before
### After
(cherry picked from commit c3f53b1)
Co-authored-by: Pierre Jeambrun
kaxil
pushed a commit
that referenced
this pull request
Oct 21, 2025
Fixes: #55899
Closes #56321
Similarly to https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/definitions/taskgroup.py#L561, we need an exit condition if the taskgroup is found in usorted graph.
Adjusted test, which indeed were not in the correct topological order.
Testing dag code:
```python
from __future__ import annotations
import datetime
import pendulum
from airflow.sdk import dag, task, task_group
@task
def get_nums() -> list[int]:
return [1, 2, 4]
@task
def times_2(n: int) -> int:
return n * 2
@task_group(group_id="process_number")
def process_number(n: int):
value = times_2(n)
return value
@task
def log_success() -> None:
print("Processed successful!")
@dag(
schedule=None,
catchup=False,
start_date=pendulum.datetime(2025, 4, 1, tz="Europe/Copenhagen"),
dagrun_timeout=datetime.timedelta(minutes=30),
dag_id="55899_bug",
)
def test():
nums = get_nums()
processed = process_number.expand(n=nums)
processed >> log_success()
test()
```
### Before
https://github.com/user-attachments/assets/d5220b87-a23b-40f7-8ecf-cb1b39d72f53" />
### After
https://github.com/user-attachments/assets/37f75b19-2e80-4765-b9cb-e425f9054b78" />
(cherry picked from commit c3f53b1)
Closes #56321
Similarly to https://github.com/apache/airflow/blob/main/task-sdk/src/airflow/sdk/definitions/taskgroup.py#L561, we need an exit condition if the taskgroup is found in usorted graph.
Adjusted test, which indeed were not in the correct topological order.
Testing dag code:
```python
from __future__ import annotations
import datetime
import pendulum
from airflow.sdk import dag, task, task_group
@task
def get_nums() -> list[int]:
return [1, 2, 4]
@task
def times_2(n: int) -> int:
return n * 2
@task_group(group_id="process_number")
def process_number(n: int):
value = times_2(n)
return value
@task
def log_success() -> None:
print("Processed successful!")
@dag(
schedule=None,
catchup=False,
start_date=pendulum.datetime(2025, 4, 1, tz="Europe/Copenhagen"),
dagrun_timeout=datetime.timedelta(minutes=30),
dag_id="55899_bug",
)
def test():
nums = get_nums()
processed = process_number.expand(n=nums)
processed >> log_success()
test()
```
### Before
### After
(cherry picked from commit c3f53b1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.