Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add is_favorite to ui dags list#56341

Merged
bbovenzi merged 2 commits intoapache:mainfrom
astronomer:add-is_favorite-to-ui-dags-response
Oct 9, 2025
Merged

Add is_favorite to ui dags list#56341
bbovenzi merged 2 commits intoapache:mainfrom
astronomer:add-is_favorite-to-ui-dags-response

Conversation

Copy link
Contributor

bbovenzi commented Oct 2, 2025

There was an issue that favoriting a dag in the dags list would break the sorting of the dags page. That was because we were querying the dags list inside of each Favorite Dag button and it affected the dags list cache. Instead, we should juse include is_favorite on the Dag response.

Also, make the Star icon stroke match the fill.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

bbovenzi added this to the Airflow 3.1.1 milestone Oct 2, 2025
boring-cyborg bot added area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. labels Oct 2, 2025
jscheffl approved these changes Oct 2, 2025
Copy link
Member

jason810496 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks for the PR!
My nits are non-blocking.

Copy link
Member

pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just one suggestion

bbovenzi requested a review from potiuk as a code owner October 7, 2025 22:13
bbovenzi force-pushed the add-is_favorite-to-ui-dags-response branch from 0276653 to 07b8fc4 Compare October 7, 2025 22:13
bbovenzi force-pushed the add-is_favorite-to-ui-dags-response branch from 07b8fc4 to fe8d84a Compare October 9, 2025 18:51
jscheffl approved these changes Oct 9, 2025
bbovenzi merged commit ba7b407 into apache:main Oct 9, 2025
111 checks passed
bbovenzi deleted the add-is_favorite-to-ui-dags-response branch October 9, 2025 20:31
bbovenzi added the backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch label Oct 9, 2025
github-actions bot pushed a commit to aws-mwaa/upstream-to-airflow that referenced this pull request Oct 9, 2025
* Add is_favorite to ui dags list

* Update dagdetails
(cherry picked from commit ba7b407)

Co-authored-by: Brent Bovenzi
abdulrahman305 bot pushed a commit to qenex-ai/airflow that referenced this pull request Oct 10, 2025
* Add is_favorite to ui dags list

* Update dagdetails
abdulrahman305 bot pushed a commit to qenex-ai/airflow that referenced this pull request Oct 11, 2025
* Add is_favorite to ui dags list

* Update dagdetails
abdulrahman305 bot pushed a commit to qenex-ai/airflow that referenced this pull request Oct 12, 2025
* Add is_favorite to ui dags list

* Update dagdetails
dabla pushed a commit to dabla/airflow that referenced this pull request Oct 12, 2025
* Add is_favorite to ui dags list

* Update dagdetails
abdulrahman305 bot pushed a commit to qenex-ai/airflow that referenced this pull request Oct 14, 2025
* Add is_favorite to ui dags list

* Update dagdetails
abdulrahman305 bot pushed a commit to qenex-ai/airflow that referenced this pull request Oct 15, 2025
* Add is_favorite to ui dags list

* Update dagdetails
abdulrahman305 bot pushed a commit to qenex-ai/airflow that referenced this pull request Oct 17, 2025
* Add is_favorite to ui dags list

* Update dagdetails
abdulrahman305 bot pushed a commit to qenex-ai/airflow that referenced this pull request Oct 19, 2025
* Add is_favorite to ui dags list

* Update dagdetails
kaxil pushed a commit that referenced this pull request Oct 21, 2025
* Add is_favorite to ui dags list

* Update dagdetails

(cherry picked from commit ba7b407)
TyrellHaywood pushed a commit to TyrellHaywood/airflow that referenced this pull request Oct 22, 2025
* Add is_favorite to ui dags list

* Update dagdetails
potiuk mentioned this pull request Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pierrejeambrun pierrejeambrun left review comments

jason810496 jason810496 left review comments

jscheffl jscheffl approved these changes

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

rawwar Awaiting requested review from rawwar rawwar is a code owner

bugraoz93 Awaiting requested review from bugraoz93 bugraoz93 is a code owner

potiuk Awaiting requested review from potiuk potiuk is a code owner

Assignees

No one assigned

Labels

area:API Airflow's REST/HTTP API area:UI Related to UI/UX. For Frontend Developers. backport-to-v3-1-test Mark PR with this label to backport to v3-1-test branch

Projects

None yet

Milestone

Airflow 3.1.1

Development

Successfully merging this pull request may close these issues.

4 participants