Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add missing .level property on our structlog shim.#55638

Merged
eladkal merged 1 commit intomainfrom
level-attr-missing-on-logger
Sep 14, 2025
Merged

Add missing .level property on our structlog shim.#55638
eladkal merged 1 commit intomainfrom
level-attr-missing-on-logger

Conversation

Copy link
Member

ashb commented Sep 13, 2025

This wasn't caught in unit tests, but it was reported that something within
Slack's python library itself is trying to access this property.

https://github.com/slackapi/python-slack-sdk/blob/ed1893d/slack_sdk/socket_mode/client.py#L98
for example


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

ramitkataria reacted with rocket emoji
This wasn't caught in unit tests, but it was reported that something within
Slack's python library itself is trying to access this property.

https://github.com/slackapi/python-slack-sdk/blob/ed1893d/slack_sdk/socket_mode/client.py#L98
for example
ashb added this to the Airflow 3.1.0 milestone Sep 13, 2025
boring-cyborg bot added the area:logging label Sep 13, 2025
Copy link
Member Author

ashb commented Sep 13, 2025

@kaxil We def need this one in 3.1.0

ashb added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Sep 13, 2025
ashb requested review from amoghrajesh, ferruzzi and kaxil September 13, 2025 20:23
eladkal approved these changes Sep 14, 2025
eladkal merged commit ee99c62 into main Sep 14, 2025
52 checks passed
eladkal deleted the level-attr-missing-on-logger branch September 14, 2025 02:56
kaxil pushed a commit that referenced this pull request Sep 14, 2025
This wasn't caught in unit tests, but it was reported that something within
Slack's python library itself is trying to access this property.

https://github.com/slackapi/python-slack-sdk/blob/ed1893d/slack_sdk/socket_mode/client.py#L98
for example

(cherry picked from commit ee99c62)
suman-himanshu pushed a commit to suman-himanshu/airflow that referenced this pull request Sep 17, 2025
This wasn't caught in unit tests, but it was reported that something within
Slack's python library itself is trying to access this property.

https://github.com/slackapi/python-slack-sdk/blob/ed1893d/slack_sdk/socket_mode/client.py#L98
for example
Brunda10 pushed a commit to Brunda10/airflow that referenced this pull request Sep 17, 2025
This wasn't caught in unit tests, but it was reported that something within
Slack's python library itself is trying to access this property.

https://github.com/slackapi/python-slack-sdk/blob/ed1893d/slack_sdk/socket_mode/client.py#L98
for example
potiuk mentioned this pull request Nov 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

eladkal eladkal approved these changes

ferruzzi Awaiting requested review from ferruzzi

kaxil Awaiting requested review from kaxil

amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

Assignees

No one assigned

Labels

area:logging changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..)

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

2 participants