-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Add EdgeExecutor to KEDA query#55560
Conversation
Description
This PR adds the EdgeExecutor to the default KEDA query in the Helm chart.
Why do we use "IS DISTINCT FROM" here for the comparison of the executor field? See: #55559
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
jscheffl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Also here) tests need to be adjusted. Otherwise looks good for me! Thanks for the extension!
Would it be also possible to reverse the match and filter only by any executor which is like "Celery" in the name and "null" is Celery is in the name of the default executor (==first)?
|
Conflicts need resolution |
I guess it should be possible to come up with a more generic query where do not need to list all executors != Celery. Maybe we can do this in a follow up PR - probably such a change requires some more testing. |
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests
* Adapt unit tests