-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Add utility function for generic filter counting#54817
Conversation
Related
Why
- There are several filter count logic could be reused.
- Lots of filters will be added in 3.1.0 and most of them would also need the function to count filter
How
- centralize filter counting logic
- dynamically count filters and preserve type safe by TypeScript generic
- add unit test for the new func
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I don't think we need the excluded fields for now, I would just remove this to not over complicate it.
We can always add that back later on if needed. This will also make the function easier to type I believe.
a585841 to
c14a4af
Compare
Sure, it would be much easier to type. Current removed and I could help update it if needed in the future! |
c14a4af to
f1bed1a
Compare
f1bed1a to
6f728e2
Compare
* Remove excludeFields from getFilterCount
* Remove excludeFields from getFilterCount