Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

AIP-86 - Implement basic functionality for deadline alerts async callbacks#53201

Merged
o-nikolas merged 1 commit intoapache:mainfrom
aws-mwaa:ramitkataria/deadlines/deadline-callbacks
Jul 21, 2025
Merged

AIP-86 - Implement basic functionality for deadline alerts async callbacks#53201
o-nikolas merged 1 commit intoapache:mainfrom
aws-mwaa:ramitkataria/deadlines/deadline-callbacks

Conversation

Copy link
Contributor

ramitkataria commented Jul 11, 2025

As discussed in dev calls and email list, async callbacks for deadline alerts will run in the triggerer. This implements foundational changes needed for the callbacks to run.

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

ramitkataria requested review from XD-DENG, ashb, dstandish, ephraimbuddy and hussein-awala as code owners July 11, 2025 17:58
boring-cyborg bot added area:db-migrations PRs with DB migration area:Triggerer kind:documentation labels Jul 11, 2025
Copy link
Contributor Author

ramitkataria commented Jul 11, 2025

I'll fix the merge conflicts and add unit tests in a bit

o-nikolas reviewed Jul 11, 2025
Copy link
Contributor

o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments so far. As you called out, needs fixes still before final review.

ramitkataria force-pushed the ramitkataria/deadlines/deadline-callbacks branch from 3242611 to f17af35 Compare July 11, 2025 22:53
ferruzzi reviewed Jul 14, 2025
ferruzzi reviewed Jul 14, 2025
ferruzzi reviewed Jul 14, 2025
o-nikolas approved these changes Jul 14, 2025
Copy link
Contributor

o-nikolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Src lgtm after comments are resolved. Should we have unit tests for any of this?

ramitkataria force-pushed the ramitkataria/deadlines/deadline-callbacks branch from f17af35 to 6d35915 Compare July 15, 2025 20:16
ramitkataria requested review from amoghrajesh, gopidesupavan, jedcunningham and potiuk as code owners July 15, 2025 20:31
Copy link
Contributor Author

ramitkataria commented Jul 15, 2025 *
edited
Loading

Src lgtm after comments are resolved. Should we have unit tests for any of this?

Thanks! Unit tests added now
o-nikolas reacted with thumbs up emoji

ferruzzi approved these changes Jul 16, 2025
Copy link
Contributor

ferruzzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My concerns were addressed. Approved pending merge conflict resolution.

vincbeck approved these changes Jul 16, 2025
ramitkataria force-pushed the ramitkataria/deadlines/deadline-callbacks branch 2 times, most recently from 76db09b to 27af90d Compare July 17, 2025 01:41
vincbeck approved these changes Jul 17, 2025
ashb reviewed Jul 17, 2025
Copy link
Member

ashb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given this a first surface-level pass

ramitkataria force-pushed the ramitkataria/deadlines/deadline-callbacks branch from 27af90d to 35696d6 Compare July 17, 2025 22:43
ashb reviewed Jul 18, 2025
ramitkataria force-pushed the ramitkataria/deadlines/deadline-callbacks branch from 8e3d4b7 to 191916e Compare July 18, 2025 17:54
ramitkataria force-pushed the ramitkataria/deadlines/deadline-callbacks branch from 191916e to 9cf3235 Compare July 18, 2025 20:21
...backs

As discussed in dev calls and [email list](https://lists.apache.org/thread/cpnngjd9vl3wszjczwqkvl13p5pvbm5d),
async callbacks for deadline alerts will run in the triggerer. This
implements foundational changes needed for the callbacks to run.
ramitkataria force-pushed the ramitkataria/deadlines/deadline-callbacks branch from 9cf3235 to 54e34a2 Compare July 18, 2025 21:10
o-nikolas merged commit f901767 into apache:main Jul 21, 2025
102 checks passed
o-nikolas deleted the ramitkataria/deadlines/deadline-callbacks branch July 21, 2025 23:40
ramitkataria mentioned this pull request Jul 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

ashb ashb left review comments

o-nikolas o-nikolas approved these changes

ferruzzi ferruzzi approved these changes

vincbeck vincbeck approved these changes

ephraimbuddy Awaiting requested review from ephraimbuddy ephraimbuddy is a code owner

dstandish Awaiting requested review from dstandish dstandish is a code owner

hussein-awala Awaiting requested review from hussein-awala hussein-awala is a code owner

XD-DENG Awaiting requested review from XD-DENG XD-DENG is a code owner

potiuk Awaiting requested review from potiuk potiuk is a code owner

jedcunningham Awaiting requested review from jedcunningham jedcunningham is a code owner

gopidesupavan Awaiting requested review from gopidesupavan gopidesupavan is a code owner

amoghrajesh Awaiting requested review from amoghrajesh amoghrajesh is a code owner

Assignees

No one assigned

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants