Light Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

feat(ui): Add Turkish Translation for the UI and CODEOWNER#51266

Merged
bugraoz93 merged 8 commits intoapache:mainfrom
bugraoz93:add-turkish-translation
Aug 21, 2025
Merged

feat(ui): Add Turkish Translation for the UI and CODEOWNER#51266
bugraoz93 merged 8 commits intoapache:mainfrom
bugraoz93:add-turkish-translation

Conversation

Copy link
Contributor

bugraoz93 commented May 31, 2025

^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in airflow-core/newsfragments.

bugraoz93 requested review from bbovenzi, jscheffl, pierrejeambrun, ryanahamilton and shubhamraj-git as code owners May 31, 2025 17:25
boring-cyborg bot added area:dev-tools area:UI Related to UI/UX. For Frontend Developers. labels May 31, 2025
shahar1 approved these changes Jun 1, 2025
Copy link
Contributor

shahar1 left a comment *
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I validated the translations with Claude and it looks good :)
I'd be happy, if possible, that a Turkish proficient person could review it as well for a human-prespective.

shahar1 self-requested a review June 1, 2025 08:35
shahar1 reviewed Jun 1, 2025
Copy link
Contributor

shahar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Taking back my approval until we decide what to do with the i18n policy, see discussion:
https://lists.apache.org/list.html?dev@airflow.apache.org

bugraoz93 reacted with eyes emoji
shahar1 self-requested a review June 1, 2025 09:11
Copy link
Contributor Author

bugraoz93 commented Jun 1, 2025

Taking back my approval until we decide what to do with the i18n policy, see discussion: https://lists.apache.org/list.html?dev@airflow.apache.org

Read it, thanks for initiating this, Shahar!
shahar1 reacted with rocket emoji

Copy link
Member

pierrejeambrun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me but can't vouch for the translation itself.

bugraoz93 force-pushed the add-turkish-translation branch 2 times, most recently from 7c40259 to 58b599f Compare June 26, 2025 20:40
aoelvp94 reviewed Jun 26, 2025
bugraoz93 commented Jun 27, 2025
Copy link

github-actions bot commented Aug 12, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
bugraoz93 reacted with confused emoji

github-actions bot added the stale Stale PRs per the .github/workflows/stale.yml policy file label Aug 12, 2025
Copy link
Contributor Author

bugraoz93 commented Aug 12, 2025 *
edited
Loading

Not stale, I will find someone
shahar1 and bbovenzi reacted with thumbs up emoji

github-actions bot removed the stale Stale PRs per the .github/workflows/stale.yml policy file label Aug 13, 2025
bugraoz93 force-pushed the add-turkish-translation branch 2 times, most recently from cf4924f to 98f8334 Compare August 20, 2025 19:16
hasancatalgol approved these changes Aug 20, 2025
Copy link

hasancatalgol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks perfect now :)

jscheffl reviewed Aug 20, 2025
jscheffl reviewed Aug 20, 2025
jscheffl reviewed Aug 20, 2025
Copy link
Contributor

jscheffl left a comment *
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just checked the missing keys and it seems main has drifted since the initial PR creation. Can you close the gaps of translation?

hint:
dev/i18n/check_translations_completeness.py -l tr --add-missing
(I assume the extra / orphan keys must be manually cleaned)

bugraoz93 reacted with thumbs up emoji
Copy link
Contributor Author

bugraoz93 commented Aug 20, 2025

I just checked the missing keys and it seems main has drifted since the initial PR creation. Can you close the gaps of translation?

hint:
dev/i18n/check_translations_completeness.py -l tr --add-missing
(I assume the extra / orphan keys must be manually cleaned)

Thanks for the hint! This command is exactly what I needed. I thought there were only missing ones but it seems there are also extra ones. I will make it full coverage soon

bugraoz93 force-pushed the add-turkish-translation branch from e3ecf28 to d99ae9d Compare August 21, 2025 00:00
Copy link
Contributor Author

bugraoz93 commented Aug 21, 2025

All done :)

jscheffl approved these changes Aug 21, 2025
bugraoz93 force-pushed the add-turkish-translation branch from d99ae9d to cdb6b00 Compare August 21, 2025 15:03
bugraoz93 force-pushed the add-turkish-translation branch from ac6f7af to 03f98b5 Compare August 21, 2025 16:06
bugraoz93 merged commit 9652ed9 into apache:main Aug 21, 2025
19 checks passed
Copy link
Contributor

jscheffl commented Aug 21, 2025

Wohoo! Cool!
bugraoz93 reacted with heart emoji

Copy link
Member

potiuk commented Aug 22, 2025

Wohoo! Cool!

Indeed:

bugraoz93 reacted with heart emoji

Copy link
Contributor

shahar1 commented Aug 23, 2025

Well done Bugra and Hasan! :)
bugraoz93, potiuk, and bbovenzi reacted with heart emoji

bugraoz93 deleted the add-turkish-translation branch August 23, 2025 22:45
bbovenzi added this to the Airflow 3.1.0 milestone Aug 25, 2025
mangal-vairalkar pushed a commit to mangal-vairalkar/airflow that referenced this pull request Aug 30, 2025
)

* feat(ui): Add Turkish Translation

* feat(i18n): Update according to comments and fill missing parts

* feat(i18n): Fill Gaps and Fix Drifts

* Update airflow-core/src/airflow/ui/src/i18n/config.ts

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

* Update .github/CODEOWNERS

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>

---------

Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

pierrejeambrun pierrejeambrun left review comments

jscheffl jscheffl approved these changes

bbovenzi Awaiting requested review from bbovenzi bbovenzi is a code owner

ryanahamilton Awaiting requested review from ryanahamilton ryanahamilton is a code owner

shubhamraj-git Awaiting requested review from shubhamraj-git shubhamraj-git is a code owner

shahar1 Awaiting requested review from shahar1

+2 more reviewers

aoelvp94 aoelvp94 left review comments

hasancatalgol hasancatalgol approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area:dev-tools area:UI Related to UI/UX. For Frontend Developers.

Projects

None yet

Milestone

Airflow 3.1.0

Development

Successfully merging this pull request may close these issues.

8 participants