-
Notifications
You must be signed in to change notification settings - Fork 16.6k
Add shortcut to clear and mark state for taskinstance and dagrun.#50885
Merged
pierrejeambrun merged 2 commits intoapache:mainfrom May 26, 2025
Merged
Add shortcut to clear and mark state for taskinstance and dagrun.#50885pierrejeambrun merged 2 commits intoapache:mainfrom
pierrejeambrun merged 2 commits intoapache:mainfrom
Conversation
Contributor
shift+sto mark task instance/dagrun as success only when the it is not in success state.shift+fto mark task instance/dagrun as failed only when the task is not in failed state.shift+cto clear task instance/dagrun.- Hotkey enabled only in details page and not in list page to avoid ambiguity of multiple modals opened.
Closes #50884
tirkarthi
requested review from
bbovenzi,
jscheffl,
pierrejeambrun,
ryanahamilton and
shubhamraj-git
as code owners
May 21, 2025 11:43
pierrejeambrun
approved these changes
May 23, 2025
Member
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, one minor nit.
airflow-core/src/airflow/ui/src/components/Clear/Run/ClearRunButton.tsx
Outdated
Show resolved
Hide resolved
pierrejeambrun
approved these changes
May 26, 2025
Member
pierrejeambrun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, working as expected.
dadonnelly316
pushed a commit
to dadonnelly316/airflow
that referenced
this pull request
May 26, 2025
...ache#50885)
* Add shortcut to clear and mark state for taskinstance and dagrun.
* Rename hasHotKey to isHotkeyEnabled.
* Add shortcut to clear and mark state for taskinstance and dagrun.
* Rename hasHotKey to isHotkeyEnabled.
sanederchik
pushed a commit
to sanederchik/airflow
that referenced
this pull request
Jun 7, 2025
...ache#50885)
* Add shortcut to clear and mark state for taskinstance and dagrun.
* Rename hasHotKey to isHotkeyEnabled.
* Add shortcut to clear and mark state for taskinstance and dagrun.
* Rename hasHotKey to isHotkeyEnabled.
jose-lehmkuhl
pushed a commit
to jose-lehmkuhl/airflow
that referenced
this pull request
Jul 11, 2025
...ache#50885)
* Add shortcut to clear and mark state for taskinstance and dagrun.
* Rename hasHotKey to isHotkeyEnabled.
* Add shortcut to clear and mark state for taskinstance and dagrun.
* Rename hasHotKey to isHotkeyEnabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.