-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Change ViewModel visibility from public to internal for all feature modules#1924
Change ViewModel visibility from public to internal for all feature modules#1924audgns10 wants to merge 9 commits intoandroid:mainfrom
Conversation
What I have done and why
-
Changed the visibility modifier of all ViewModel classes within their respective feature modules from public to internal, ensuring that ViewModels are only accessible within their own modules.
-
This modification improves encapsulation and enforces clear module boundaries, preventing unintended usage of ViewModels across modules.
-
By restricting access with the internal modifier, the codebase becomes more maintainable and less prone to unintended dependencies.
-
Updated each feature module separately to reflect this visibility change, keeping each commit modular and easier to review.
Updated Modules
The following feature modules have been updated:
- BookmarksViewModel (in feature-bookmarks)
- ForYouViewModel (in feature-foryou)
- SearchViewModel (in feature-search)
audgns10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would appreciate it if you could take a look at this PR when you get the chance
Made some visibility changes to ViewModels for better encapsulation between modules.
Happy to make any changes if needed!
hoc081098
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
audgns10
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dturner please take a look at this PR when you have time