Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Change ViewModel visibility from public to internal for all feature modules#1924

Open
audgns10 wants to merge 9 commits intoandroid:mainfrom
audgns10:refactor/internal-viewmodels
Open

Change ViewModel visibility from public to internal for all feature modules#1924
audgns10 wants to merge 9 commits intoandroid:mainfrom
audgns10:refactor/internal-viewmodels

Conversation

Copy link

audgns10 commented Aug 2, 2025

What I have done and why

  • Changed the visibility modifier of all ViewModel classes within their respective feature modules from public to internal, ensuring that ViewModels are only accessible within their own modules.

  • This modification improves encapsulation and enforces clear module boundaries, preventing unintended usage of ViewModels across modules.

  • By restricting access with the internal modifier, the codebase becomes more maintainable and less prone to unintended dependencies.

  • Updated each feature module separately to reflect this visibility change, keeping each commit modular and easier to review.


Updated Modules

The following feature modules have been updated:

  • BookmarksViewModel (in feature-bookmarks)
  • ForYouViewModel (in feature-foryou)
  • SearchViewModel (in feature-search)

nur-shuvo reacted with thumbs up emoji
audgns10 requested a review from dturner as a code owner August 2, 2025 19:05
audgns10 commented Aug 2, 2025
Copy link
Author

audgns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dturner

Would appreciate it if you could take a look at this PR when you get the chance
Made some visibility changes to ViewModels for better encapsulation between modules.
Happy to make any changes if needed!

hoc081098 reviewed Aug 3, 2025
Copy link
Contributor

hoc081098 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

audgns10 commented Sep 20, 2025
Copy link
Author

audgns10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dturner please take a look at this PR when you have time

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

dturner Awaiting requested review from dturner dturner is a code owner

1 more reviewer

hoc081098 hoc081098 left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants