Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Make core generic over float types#373

Draft
wolfd wants to merge 1 commit intoalphaville:masterfrom
AutoPallet:master
Draft

Make core generic over float types#373
wolfd wants to merge 1 commit intoalphaville:masterfrom
AutoPallet:master

Conversation

Copy link

wolfd commented Sep 4, 2025

Main Changes

I wanted to try the core crate out on a microcontroller that just has hard-floats for f32, so I hacked this together. I'm only using PANOC without constraints, so I'm not sure if anything really works that well outside of what I used. Perhaps the complexity is somewhat inevitable to support f32/f64, but it's annoying how much extra boilerplate is added with this. Nonetheless, it could be a good basis for adding f32 support here.

  • Make a OptFloat trait
  • Provide PANOC constants implemented for f32 and f64
  • Use somewhat arbitrary values for f32 PANOC constants, unclear how good these are. These should be looked at.
  • Add some tests for f32 (some of which are failing!)

Associated Issues

TODOs

  • Documentation
  • All tests must pass
  • Update CHANGELOG(s)
  • Update webpage documentation
  • Bump versions (in CHANGELOG, Cargo.toml and VERSION)
  • Use non-forked version of lbfgs-rs

- Make a OptFloat trait
- Provide PANOC constants implemented for f32 and f64
- Use somewhat arbitrary values for f32 PANOC constants, unclear how good
these are. These should be looked at.
- Add some tests for f32 (some of which are failing!)
wolfd mentioned this pull request Sep 4, 2025
wolfd force-pushed the master branch from 8f864dd to 7bedc3d Compare November 19, 2025 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant