Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Sign up
Appearance settings

Add dropzone accessibility#10

Open
RakibRahman wants to merge 3 commits intoaddyosmani:mainfrom
RakibRahman:add-dropzone-accessibility
Open

Add dropzone accessibility#10
RakibRahman wants to merge 3 commits intoaddyosmani:mainfrom
RakibRahman:add-dropzone-accessibility

Conversation

Copy link

RakibRahman commented Feb 8, 2025

feat: add keyboard navigation support to DropZone

  • Made DropZone focusable with tabIndex={0}.
  • Added onKeyDown handler for Enter/Space key support.
  • Improved accessibility with role="button" and aria-label.
  • Enhanced focus styles for better usability.

Preview:

Copy link

netlify bot commented Feb 8, 2025 *
edited
Loading

Deploy Preview for squish-image ready!

Name Link
Latest commit 896455e
Latest deploy log https://app.netlify.com/sites/squish-image/deploys/67c8b07be5c9b30008086629
Deploy Preview https://deploy-preview-10--squish-image.netlify.app
Preview on mobile
Toggle QR Code...



Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coliff approved these changes Feb 21, 2025
Copy link

coliff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested this - it's a helpful addition. You can use it with just a keyboard now!

RakibRahman reacted with heart emoji
Copy link

coliff commented Feb 21, 2025

Would be great to fix this accessibility issue too:
RakibRahman reacted with thumbs up emoji

Copy link
Author

RakibRahman commented Mar 5, 2025

fixed accessibility issues for the image quality input.
coliff reacted with thumbs up emoji

RakibRahman requested a review from coliff March 5, 2025 20:17
coliff approved these changes Mar 6, 2025
Copy link

mathcrln commented Aug 4, 2025

Hey @coliff, I have been checking out this pull request along with a couple of other recent ones and I'm loving all of the changes introduced by all these contributors! I see you already approved this PR, what would it take to merge it into production?

I'm already excited to use the changes introduced in #13 and #15 :)

Copy link

coliff commented Aug 4, 2025

I'm not an admin of this repo... I think only @addyosmani is able to merge. Hopefully he'll get round to it soon!
mathcrln reacted with thumbs up emoji

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

coliff coliff approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants