Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Chore: correct the params used with the peaceiris/actions-gh-pages@v4 plugin [#3735]#3736

Merged
cahirodoherty-learningpool merged 1 commit intomasterfrom
issue/3735
Dec 10, 2025
Merged

Chore: correct the params used with the peaceiris/actions-gh-pages@v4 plugin [#3735]#3736
cahirodoherty-learningpool merged 1 commit intomasterfrom
issue/3735

Conversation

Copy link
Contributor

cahirodoherty-learningpool commented Dec 10, 2025

Fixes #3735

Chore

  • correct the params used with the peaceiris/actions-gh-pages@v4 plugin

oliverfoster added this to adapt_framework: The TODO Board Dec 10, 2025
github-project-automation bot moved this to New in adapt_framework: The TODO Board Dec 10, 2025
cahirodoherty-learningpool requested review from Copilot, ethan-lp, lemmyadams, oliverfoster and swashbuck December 10, 2025 10:19
Copilot started reviewing on behalf of cahirodoherty-learningpool December 10, 2025 10:20 View session
Copilot AI reviewed Dec 10, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR corrects the authentication parameter used with the peaceiris/actions-gh-pages@v4 GitHub Action in the deployment workflow, changing from deploy_key to personal_token to properly align with the token type being used. Additionally, it includes minor formatting improvements for consistency.

  • Changes the authentication parameter from deploy_key to personal_token for the peaceiris/actions-gh-pages@v4 action
  • Standardizes string quotes from single to double quotes throughout the workflow
  • Removes trailing whitespace for cleaner formatting

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

ethan-lp approved these changes Dec 10, 2025
lemmyadams approved these changes Dec 10, 2025
swashbuck approved these changes Dec 10, 2025
Copy link
Contributor

swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cahirodoherty-learningpool merged commit e175958 into master Dec 10, 2025
8 checks passed
cahirodoherty-learningpool deleted the issue/3735 branch December 10, 2025 17:12
github-project-automation bot moved this from New to Recently Released in adapt_framework: The TODO Board Dec 10, 2025
swashbuck mentioned this pull request Dec 22, 2025
Copy link
Contributor

swashbuck commented Dec 22, 2025 *
edited
Loading

The v5 demo site is not loading. Created #3737

github-actions bot pushed a commit that referenced this pull request Dec 30, 2025
## [5.54.1](v5.54.0...v5.54.1) (2025-12-30)

### Chore

* correct the params used with the peaceiris/actions-gh-pages@v4 plugin (#3736) ([e175958](e175958)), closes [#3736](#3736)

### Fix

* Bumping core to v6.72.2 automatically via 'frameworkpullrequest' Github action (#3739) ([0c9c744](0c9c744)), closes [#3739](#3739)
Copy link

github-actions bot commented Dec 30, 2025

This PR is included in version 5.54.1

The release is available on GitHub release

Your semantic-release bot

github-actions bot added the released label Dec 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

swashbuck swashbuck approved these changes

ethan-lp ethan-lp approved these changes

lemmyadams lemmyadams approved these changes

oliverfoster Awaiting requested review from oliverfoster

Assignees

No one assigned

Labels

Projects

Status: Recently Released

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

GitHub pages workflow is failing

5 participants