-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Bump undici from 5.28.5 to 5.29.0 #1295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking "Sign up for GitHub", you agree to our terms of service and privacy statement. We'll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Bump undici from 5.28.5 to 5.29.0 #1295
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -64080,7 +64080,7 @@ module.exports = { | |
|
|
||
|
|
||
| const { parseSetCookie } = __nccwpck_require__(8915) | ||
| const { stringify, getHeadersList } = __nccwpck_require__(3834) | ||
| const { stringify } = __nccwpck_require__(3834) | ||
| const { webidl } = __nccwpck_require__(4222) | ||
| const { Headers } = __nccwpck_require__(6349) | ||
|
|
||
|
|
@@ -64156,14 +64156,13 @@ function getSetCookies (headers) { | |
|
|
||
| webidl.brandCheck(headers, Headers, { strict: false }) | ||
|
|
||
| const cookies = getHeadersList(headers).cookies | ||
| const cookies = headers.getSetCookie() | ||
|
|
||
| if (!cookies) { | ||
| return [] | ||
| } | ||
|
|
||
| // In older versions of undici, cookies is a list of name:value. | ||
| return cookies.map((pair) => parseSetCookie(Array.isArray(pair) ? pair[1] : pair)) | ||
| return cookies.map((pair) => parseSetCookie(pair)) | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -64591,14 +64590,15 @@ module.exports = { | |
| /***/ }), | ||
|
|
||
| /***/ 3834: | ||
| /***/ ((module, __unused_webpack_exports, __nccwpck_require__) => { | ||
| /***/ ((module) => { | ||
|
|
||
| "use strict"; | ||
|
|
||
|
|
||
| const assert = __nccwpck_require__(2613) | ||
| const { kHeadersList } = __nccwpck_require__(6443) | ||
|
|
||
| /** | ||
| * @param {string} value | ||
| * @returns {boolean} | ||
| */ | ||
| function isCTLExcludingHtab (value) { | ||
| if (value.length === 0) { | ||
| return false | ||
|
|
@@ -64859,31 +64859,13 @@ function stringify (cookie) { | |
| return out.join('; ') | ||
| } | ||
|
|
||
| let kHeadersListNode | ||
|
|
||
| function getHeadersList (headers) { | ||
| if (headers[kHeadersList]) { | ||
| return headers[kHeadersList] | ||
| } | ||
|
|
||
| if (!kHeadersListNode) { | ||
| kHeadersListNode = Object.getOwnPropertySymbols(headers).find( | ||
| (symbol) => symbol.description === 'headers list' | ||
| ) | ||
|
|
||
| assert(kHeadersListNode, 'Headers cannot be parsed') | ||
| } | ||
|
|
||
| const headersList = headers[kHeadersListNode] | ||
| assert(headersList) | ||
|
|
||
| return headersList | ||
| } | ||
|
|
||
| module.exports = { | ||
| isCTLExcludingHtab, | ||
| stringify, | ||
| getHeadersList | ||
| validateCookieName, | ||
| validateCookiePath, | ||
| validateCookieValue, | ||
| toIMFDate, | ||
| stringify | ||
| } | ||
|
|
||
|
|
||
|
|
@@ -68887,6 +68869,7 @@ const { | |
| isValidHeaderName, | ||
| isValidHeaderValue | ||
| } = __nccwpck_require__(5523) | ||
| const util = __nccwpck_require__(9023) | ||
| const { webidl } = __nccwpck_require__(4222) | ||
| const assert = __nccwpck_require__(2613) | ||
|
|
||
|
|
@@ -69440,6 +69423,9 @@ Object.defineProperties(Headers.prototype, { | |
| [Symbol.toStringTag]: { | ||
| value: 'Headers', | ||
| configurable: true | ||
| }, | ||
| [util.inspect.custom]: { | ||
| enumerable: false | ||
| } | ||
| }) | ||
|
|
||
|
|
@@ -78616,6 +78602,20 @@ class Pool extends PoolBase { | |
| ? { ...options.interceptors } | ||
| : undefined | ||
| this[kFactory] = factory | ||
|
|
||
| this.on('connectionError', (origin, targets, error) => { | ||
| // If a connection error occurs, we remove the client from the pool, | ||
| // and emit a connectionError event. They will not be re-used. | ||
| // Fixes https://github.com/nodejs/undici/issues/3895 | ||
| for (const target of targets) { | ||
| // Do not use kRemoveClient here, as it will close the client, | ||
| // but the client cannot be closed in this state. | ||
| const idx = this[kClients].indexOf(target) | ||
| if (idx !== -1) { | ||
| this[kClients].splice(idx, 1) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| [kGetDispatcher] () { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -72068,7 +72068,7 @@ module.exports = { | |
|
|
||
|
|
||
| const { parseSetCookie } = __nccwpck_require__(8915) | ||
| const { stringify, getHeadersList } = __nccwpck_require__(3834) | ||
| const { stringify } = __nccwpck_require__(3834) | ||
| const { webidl } = __nccwpck_require__(4222) | ||
| const { Headers } = __nccwpck_require__(6349) | ||
|
|
||
|
|
@@ -72144,14 +72144,13 @@ function getSetCookies (headers) { | |
|
|
||
| webidl.brandCheck(headers, Headers, { strict: false }) | ||
|
|
||
| const cookies = getHeadersList(headers).cookies | ||
| const cookies = headers.getSetCookie() | ||
|
|
||
| if (!cookies) { | ||
| return [] | ||
| } | ||
|
|
||
| // In older versions of undici, cookies is a list of name:value. | ||
| return cookies.map((pair) => parseSetCookie(Array.isArray(pair) ? pair[1] : pair)) | ||
| return cookies.map((pair) => parseSetCookie(pair)) | ||
| } | ||
|
|
||
| /** | ||
|
|
@@ -72579,14 +72578,15 @@ module.exports = { | |
| /***/ }), | ||
|
|
||
| /***/ 3834: | ||
| /***/ ((module, __unused_webpack_exports, __nccwpck_require__) => { | ||
| /***/ ((module) => { | ||
|
|
||
| "use strict"; | ||
|
|
||
|
|
||
| const assert = __nccwpck_require__(2613) | ||
| const { kHeadersList } = __nccwpck_require__(6443) | ||
|
|
||
| /** | ||
| * @param {string} value | ||
| * @returns {boolean} | ||
| */ | ||
| function isCTLExcludingHtab (value) { | ||
| if (value.length === 0) { | ||
| return false | ||
|
|
@@ -72847,31 +72847,13 @@ function stringify (cookie) { | |
| return out.join('; ') | ||
| } | ||
|
|
||
| let kHeadersListNode | ||
|
|
||
| function getHeadersList (headers) { | ||
| if (headers[kHeadersList]) { | ||
| return headers[kHeadersList] | ||
| } | ||
|
|
||
| if (!kHeadersListNode) { | ||
| kHeadersListNode = Object.getOwnPropertySymbols(headers).find( | ||
| (symbol) => symbol.description === 'headers list' | ||
| ) | ||
|
|
||
| assert(kHeadersListNode, 'Headers cannot be parsed') | ||
| } | ||
|
|
||
| const headersList = headers[kHeadersListNode] | ||
| assert(headersList) | ||
|
|
||
| return headersList | ||
| } | ||
|
|
||
| module.exports = { | ||
| isCTLExcludingHtab, | ||
| stringify, | ||
| getHeadersList | ||
| validateCookieName, | ||
| validateCookiePath, | ||
| validateCookieValue, | ||
| toIMFDate, | ||
| stringify | ||
| } | ||
|
|
||
|
|
||
|
|
@@ -76875,6 +76857,7 @@ const { | |
| isValidHeaderName, | ||
| isValidHeaderValue | ||
| } = __nccwpck_require__(5523) | ||
| const util = __nccwpck_require__(9023) | ||
| const { webidl } = __nccwpck_require__(4222) | ||
| const assert = __nccwpck_require__(2613) | ||
|
|
||
|
|
@@ -77428,6 +77411,9 @@ Object.defineProperties(Headers.prototype, { | |
| [Symbol.toStringTag]: { | ||
| value: 'Headers', | ||
| configurable: true | ||
| }, | ||
| [util.inspect.custom]: { | ||
| enumerable: false | ||
| } | ||
| }) | ||
|
|
||
|
|
@@ -86604,6 +86590,20 @@ class Pool extends PoolBase { | |
| ? { ...options.interceptors } | ||
| : undefined | ||
| this[kFactory] = factory | ||
|
|
||
| this.on('connectionError', (origin, targets, error) => { | ||
| // If a connection error occurs, we remove the client from the pool, | ||
| // and emit a connectionError event. They will not be re-used. | ||
| // Fixes https://github.com/nodejs/undici/issues/3895 | ||
| for (const target of targets) { | ||
| // Do not use kRemoveClient here, as it will close the client, | ||
| // but the client cannot be closed in this state. | ||
| const idx = this[kClients].indexOf(target) | ||
| if (idx !== -1) { | ||
| this[kClients].splice(idx, 1) | ||
| } | ||
| } | ||
| }) | ||
| } | ||
|
|
||
| [kGetDispatcher] () { | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.