-
-
Notifications
You must be signed in to change notification settings - Fork 711
Refactor and fix package assembly for installed wheels#4171
Refactor and fix package assembly for installed wheels#4171AyanSinhaMahapatra merged 3 commits intodevelopfrom
Conversation
Reference: #4167
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors. - Commits are in uniquely-named feature branch and has no merge conflicts
- Updated documentation pages (if applicable)
- Updated CHANGELOG.rst (if applicable)
Reference: aboutcode-org/scancode-toolkit#4167
Signed-off-by: Ayan Sinha Mahapatra
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Just a few nits for your consideration, and this is good to merge,
...de/data/pypi/site-packages/codebase/lib/python3.9/site-packages/click-8.0.4.dist-info/RECORD
Outdated
Show resolved
Hide resolved
|
CI for python 3.10 on ubuntu22 is failing pretty consistently with python/cpython#83085 which is not related to changes. Ready to review again |
4262dc6 to
c4f78b4
Compare
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After all, checking for "site-packages" dir was a mistaken suggestion!
cbc2670 to
92b7dae
Compare
4e567d8 to
0bd356c
Compare
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go! Thanks
| click-8.0.4.dist-info/WHEEL,sha256=G16H4A3IeoQmnOrYV4ueZGKSjhipXx8zc8nu9FGlvMA,92 | ||
| click-8.0.4.dist-info/top_level.txt,sha256=J1ZQogalYS4pphY_lPECoNMfw0HzTSrZglC4Yfwo4xA,6 | ||
| click/__init__.py,sha256=bOKrvMqmR9rN07vN_ycyrdF-EcTCl-EmuAjq-Fp4yPM,3243 | ||
| click/__pycache__/__init__.cpython-36.pyc,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note that these are added at installation time to RECORD... removing all these means your RECORD file is closer to that of RECORD in a .whl archive and not like the one from a site-packages installed wheel but I guess this is OK since you have a pip example of an as-installed wheel below
Reference: aboutcode-org/scancode-toolkit#4167
Signed-off-by: Ayan Sinha Mahapatra