-
-
Notifications
You must be signed in to change notification settings - Fork 711
change default value of --process to (number of CPUs)-1#4104
change default value of --process to (number of CPUs)-1#4104AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
Conversation
Related: #2980
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- [-] Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors.
Test suite fails to run for me, but the script run correctly. - Commits are in uniquely-named feature branch and has no merge conflicts
- Updated documentation pages (if applicable)
- Updated CHANGELOG.rst (if applicable)
cc8c78b to
4ded913
Compare
|
I believe the tests failures on MacOS is not relevant to this code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xsuchy Thanks++ for the PR.
Overall this sounds like a nice idea, to increase the number of CPUs by default.
It seems like we have an agreement to have this at n-1 from #2980, and this sounds mostly fine to me, although n-2 could have been safer when users might have multiple other things open/in use if they are running scancode in their personal computers. But everywhere else this sounds great, and folks can always reduce the default CPU if it creates problems.
Not sure about the test failures, could you merge latest develop just to be sure?
@pombredanne please review this too.
|
Rebased on top of develop branch. |
DennisClark
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
excellent improvement!
|
Thanks++ @xsuchy, this is a great addition! Merging. |
275d0df
into
aboutcode-org:develop