-
-
Notifications
You must be signed in to change notification settings - Fork 711
Detect go binary packages#3894
Merged
AyanSinhaMahapatra merged 7 commits intodevelopfrom Oct 19, 2024
Merged
Conversation
Member
This PR add support to scan Go binaries for their embedded packages. This is the ScanCode side.
The Go inspector PR is at
- Detect go packages go-inspector#15 and need to be merged first and released for things to work
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors. - Commits are in uniquely-named feature branch and has no merge conflicts
- Updated documentation pages (if applicable)
- Updated CHANGELOG.rst (if applicable)
Reference: aboutcode-org/go-inspector#15
Reference: aboutcode-org/go-inspector#13
Signed-off-by: Philippe Ombredanne
Reference: aboutcode-org/go-inspector#13
Signed-off-by: Philippe Ombredanne
pombredanne
force-pushed
the
detect-go-binary-packages
branch
from
September 5, 2024 18:46
2217d75 to
434322f
Compare
Signed-off-by: Philippe Ombredanne
pombredanne
force-pushed
the
detect-go-binary-packages
branch
from
September 5, 2024 19:09
434322f to
038eb03
Compare
Signed-off-by: Philippe Ombredanne
Signed-off-by: Philippe Ombredanne
Signed-off-by: Philippe Ombredanne
Member
Author
|
@AyanSinhaMahapatra ready for your review |
AyanSinhaMahapatra
approved these changes
Sep 6, 2024
Member
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @pombredanne
Can be merged with a minor nit resolved.
Member
|
I'm getting a: INFO: pip is looking at multiple versions of scancode-toolkit[packages,testing] to determine which version is compatible with other requirements. This could take a while.
On running Edit: seems to be a fluke, not happening anymore |
Member
|
I think https://github.com/aboutcode-org/go-inspector/blob/main/src/go_inspector/binary.py#L482 should be in packagedcode here? Or do we need #3761 to be merged before that? |
Signed-off-by: Philippe Ombredanne
Co-authored-by: Ayan Sinha Mahapatra
Member
|
Thanks @pombredanne , merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.