-
-
Notifications
You must be signed in to change notification settings - Fork 711
Add handler for packages.lock.json in nuget#3825
Add handler for packages.lock.json in nuget#3825AyanSinhaMahapatra merged 12 commits intodevelopfrom
Conversation
Reference: aboutcode-org/scancode.io#1263
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors. - Commits are in uniquely-named feature branch and has no merge conflicts
- Updated documentation pages (if applicable)
- Updated CHANGELOG.rst (if applicable)
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks++ @TG1999
See comments for a few questions and changes.
Also, typically we have lockfiles beside another package manifest right?
I was looking for examples of this and is this .csproj files for nuget? Are there other manifests which would be nice to parse and store?
Here is an example of a .csproj file and packages.lock.json together: https://github.com/ncblakely/GiantsTools/tree/main/Giants.Services to add as tests.
Should we not also do some lightweight package assembly here?
|
Adressed all review comments, feel free to merge. |
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks++ @TG1999 merging!