-
-
Notifications
You must be signed in to change notification settings - Fork 711
Refine referenced filenames #3547#3681
Merged
AyanSinhaMahapatra merged 5 commits intodevelopfrom Mar 19, 2024
Merged
Conversation
Member
This PR refine how we handle "referenced filenames" that we track in license detection rules.
We use improved heuristics to decide if a something detected like "See license in COPYING" will follow the license found in the file "COPYING" or not follow and reuse it in the detection, as suggested in the issue:
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors. - Commits are in uniquely-named feature branch and has no merge conflicts
- Updated documentation pages (if applicable)
- Updated CHANGELOG.rst (if applicable)
Signed-off-by: Ayan Sinha Mahapatra
Signed-off-by: Ayan Sinha Mahapatra
Signed-off-by: Ayan Sinha Mahapatra
AyanSinhaMahapatra
force-pushed
the
update-referenced-files
branch
from
March 18, 2024 11:22
e322646 to
49da477
Compare
pombredanne
changed the title
Refine referenced filenames
Refine referenced filenames #3547
Mar 18, 2024
pombredanne
requested changes
Mar 18, 2024
Member
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
You may want to add a few other test cases... the current case that passes is not correct.
tests/licensedcode/data/plugin_license/ignored_reference/or_and_problem.expected.json
Show resolved
Hide resolved
Signed-off-by: Ayan Sinha Mahapatra
AyanSinhaMahapatra
force-pushed
the
update-referenced-files
branch
from
March 19, 2024 09:31
d6f8109 to
5f28d5c
Compare
pombredanne
approved these changes
Mar 19, 2024
Member
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.