-
-
Notifications
You must be signed in to change notification settings - Fork 711
Update license detections#3620
Merged
AyanSinhaMahapatra merged 12 commits intodevelopfrom Jan 16, 2024
Merged
Conversation
Member
This adds the following LicenseDetection updates:
- Adds a
from-fileattribute with LicenseMatch origin No way to obtain LicenseMatch origin #3608 - Adds a new
reference-matchesattribute at top-level LicenseDetection objects - Add SPDX license-expression everywhere we have license-expression (i.e in detections and also matches?)
- Adds all rule attribute level info for detections in
--todo - Reorder LicenseMatch attributes
- Add a new attribute for license text diagnostics
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors. - Commits are in uniquely-named feature branch and has no merge conflicts
- Looked for possible updates in documentation and added updates if applicable
- Updated CHANGELOG.rst
Adds a new attribute to document the origin path from matches
so we can determine in the cases of de-referenced matches, the
location these came from, and also to differentiate between
matches that come from the same file or from a different file.
Signed-off-by: Ayan Sinha Mahapatra
so we can determine in the cases of de-referenced matches, the
location these came from, and also to differentiate between
matches that come from the same file or from a different file.
Signed-off-by: Ayan Sinha Mahapatra
Here `from-file` attributes were being assigned after creation of
top level packages so we had them empty. Adds a temporary fix to
this.
Signed-off-by: Ayan Sinha Mahapatra
top level packages so we had them empty. Adds a temporary fix to
this.
Signed-off-by: Ayan Sinha Mahapatra
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
December 7, 2023 12:25
9a49600 to
dbffe43
Compare
Signed-off-by: Ayan Sinha Mahapatra
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
December 7, 2023 15:22
37ef122 to
a1fc5d8
Compare
In case of license detection issues in todo items,
add rule attributes as additional context which are
usually not added to license match data.
Signed-off-by: Ayan Sinha Mahapatra
add rule attributes as additional context which are
usually not added to license match data.
Signed-off-by: Ayan Sinha Mahapatra
Adds a new attribute license_expression_spdx to both LicenseMatch and
LicenseDetection objects, and reflected also in top-level detections and
todo items. Basically this adds the SPDX license-expression everywhere
we have a license-expression.
Signed-off-by: Ayan Sinha Mahapatra
LicenseDetection objects, and reflected also in top-level detections and
todo items. Basically this adds the SPDX license-expression everywhere
we have a license-expression.
Signed-off-by: Ayan Sinha Mahapatra
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
December 12, 2023 16:28
e54472f to
e10358e
Compare
Signed-off-by: Ayan Sinha Mahapatra
Signed-off-by: Shaikh Mohd Tehami
This commit adds a new attribute for license text diagnostics
which will be added when the CLI option `--license-text-diagnostics`
is used, in contrast to earlier behaviour, where this diagnostics
matched text used to overwrite the text in `matched_text`.
Also makes sure top-level license/package summarizations have
matched text and diagnostics correcttly only when the respective
CLI options are used.
Signed-off-by: Ayan Sinha Mahapatra
which will be added when the CLI option `--license-text-diagnostics`
is used, in contrast to earlier behaviour, where this diagnostics
matched text used to overwrite the text in `matched_text`.
Also makes sure top-level license/package summarizations have
matched text and diagnostics correcttly only when the respective
CLI options are used.
Signed-off-by: Ayan Sinha Mahapatra
This was referenced Dec 20, 2023
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
December 21, 2023 15:26
dc0bd5d to
1af3877
Compare
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
January 9, 2024 16:34
84d9650 to
2ddb31c
Compare
Fixes the SPDX rule identifier mismatch bug by getting rid of
extra space introduced in SPDX license declaration detection
and text cleaning. Also enforce python safe names for identifiers.
Reference: #3634
Signed-off-by: Ayan Sinha Mahapatra
extra space introduced in SPDX license declaration detection
and text cleaning. Also enforce python safe names for identifiers.
Reference: #3634
Signed-off-by: Ayan Sinha Mahapatra
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
January 10, 2024 13:48
8c1c37f to
c631e73
Compare
pombredanne
approved these changes
Jan 15, 2024
Member
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are a few nits for your consideration.
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
January 16, 2024 18:27
2cf3a77 to
2d72d2f
Compare
AyanSinhaMahapatra
force-pushed
the
update-license-detections
branch
from
January 16, 2024 18:46
2d72d2f to
2f80ae3
Compare
Signed-off-by: Ayan Sinha Mahapatra
Signed-off-by: Ayan Sinha Mahapatra
Member
Author
|
Thanks @pombredanne, addressed everything from your suggestions. Merging now! |
This was referenced Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.