-
-
Notifications
You must be signed in to change notification settings - Fork 711
TestRule.test_dump_rule_file: sort the rule file lists.#3582
Merged
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom Nov 15, 2023
Merged
TestRule.test_dump_rule_file: sort the rule file lists.#3582AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
AyanSinhaMahapatra merged 1 commit intoaboutcode-org:developfrom
Conversation
Contributor
Fixes #3581.
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors. - Commits are in uniquely-named feature branch and has no merge conflicts
- Looked for possible updates in documentation and added updates if applicable
- Updated CHANGELOG.rst
pombredanne
approved these changes
Nov 13, 2023
Member
pombredanne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you ++
Member
|
Thanks ++ @licquia , merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.