-
-
Notifications
You must be signed in to change notification settings - Fork 711
Merged
Conversation
Member
Add a few new misc. rules to imporve license detection
Tasks
- Reviewed contribution guidelines
- PR is descriptively titled and links the original issue above
- Tests pass -- look for a green checkbox a few minutes after opening your PR
Run tests locally to check for errors. - Commits are in uniquely-named feature branch and has no merge conflicts
- Looked for possible updates in documentation and added updates if applicable
- Updated CHANGELOG.rst
Signed-off-by: Philippe Ombredanne
These are misc. rules, mostly seen in Maven POMs
Also deprecate a few LGPL-3.0 rules that were incorrect and
replace by LGPL-2.1 rules
Signed-off-by: Philippe Ombredanne
Also deprecate a few LGPL-3.0 rules that were incorrect and
replace by LGPL-2.1 rules
Signed-off-by: Philippe Ombredanne
Signed-off-by: Ayan Sinha Mahapatra
These are misc. rules, mostly seen in Maven POMs
Signed-off-by: Philippe Ombredanne
Signed-off-by: Philippe Ombredanne
Signed-off-by: Ayan Sinha Mahapatra
AyanSinhaMahapatra
approved these changes
Nov 6, 2023
Member
AyanSinhaMahapatra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All green!
LGTM @pombredanne I've added some too
Merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.