-
Notifications
You must be signed in to change notification settings - Fork 802
wasm2c: update Windows build to always use internal sha256 library to resolve libcrypto DLL not found issue#2611
wasm2c: update Windows build to always use internal sha256 library to resolve libcrypto DLL not found issue#2611silbinarywolf wants to merge 1 commit intoWebAssembly:mainfrom
Conversation
sbc100
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really know enough about windows to know if this is the correct change.
Are you saying that Windows version prior to 11 do ship libcrypo.dll by default but Windows 11 does not? Its a little supprising to me that MS would break existing programs by making a change like. Do you have any links to information about this change?
@shravanrn @keithw do either you use windows much? Did you know anything about this issue?
|
I don't use Windows myself, but I think this libcrypto stuff has been causing us enough trouble (on platforms that are maybe not as strong at versioning/managing dependencies) that we should probably just switch to an always-vendored BLAKE3 hash for this and ditch the external library. I'll send a PR on this. |