-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Open
Conversation
|
Has this been added? All I want to do is change msecs to use a period instead of a comma. |
echnio
approved these changes
Sep 17, 2021
|
@mnaberez This has been approved, can it be merged? |
Member
The individual who has approved this is not a developer on this project (on GitHub, anyone can hit the approve button). I've been @-mentioned here several times but I haven't actually looked at this, sorry. If one of the other developers with commit access approves it, they can just merge it. I'm currently working on other issues. |
|
Guys, it looks like cool functionality. And it wait for your validation. |
|
This is a great feature, I can't wait for it to be merged! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.