Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

error_threshold_timeout_enabled can open too aggressively #634

Open
Open
error_threshold_timeout_enabled can open too aggressively#634
Assignees

Description

This option was introduced in #418, which is meant to open on consecutive errors, regardless of time window. However, its implementation does not really take "consecutiveness" into account, causing it to open incorrectly.

For example, with an error_threshold of 2, and error_threshold_timeout_enabled set to false, the following might cause the circuit to open:

error -> success -> success -> success -> success -> ....10000 more successes -> error

This is not the desired behaviour

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions