-
Notifications
You must be signed in to change notification settings - Fork 182
Committing AEAD marker traits and generic constructions#564
Open
rlee287 wants to merge 8 commits intoRustCrypto:masterfrom
Open
Committing AEAD marker traits and generic constructions#564rlee287 wants to merge 8 commits intoRustCrypto:masterfrom
rlee287 wants to merge 8 commits intoRustCrypto:masterfrom
Conversation
This is a successor to the PR RustCrypto/traits#1365.
Notes for the future as to schemes I chose not to implement:
- Appending a hash of the key to the tag: This scheme would provide key-commitment security, but it has catastrophic interactions with the naive key rotation scheme of replacing a key by hashing the existing one.
- CTX+: An attacker that obtains the inner tag of a ciphertext may be able to perform a length extension attack by extending the AAD to forge a new tag. (Admittedly, this is an unlikely attack scenario, but this consideration was what led me to create CTXish-HMAC instead of a CTX+ish-HMAC.)
...o-std targets
Annoying consequence of still using Cargo resolver v1 instead of v2
Annoying consequence of still using Cargo resolver v1 instead of v2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.