-
Notifications
You must be signed in to change notification settings - Fork 149
Support chain designations of multiple letters.#551
Support chain designations of multiple letters.#551roccomoretti wants to merge 18 commits intoRosettaCommons:mainfrom
Conversation
Part of the "better support for mmCIF format" effort.
The mmCIF format supports larger systems with multi-character chain designations. This PR changes the internals of Rosetta to support multi-letter chain designations. There shouldn't be any significant behavioral changes if you just continue to use single letter chain designations.
The most significant interface change was the change in interface designation. Instead of strings like "A_B", code now generally takes a core::pose::DockingPartners object. (This can be created from the string designation, to ease IO - it should be invisible except perhaps at the PyRosetta level.)
Places that needed to be fixed were discovered primarily with type change issues during compilation. I may have missed some places which need updated support.
Apologies for the massive size of this PR, it would be hard to make such a fundamental change in any smaller unit.
lyskov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tentatively approving, pending successful test runs.