-
Notifications
You must be signed in to change notification settings - Fork 61
Align SequentialModule.add_module behavior with torch.nn.Module.add_module#82
Open
dmklee wants to merge 1 commit intoQUVA-Lab:masterfrom
Open
Align SequentialModule.add_module behavior with torch.nn.Module.add_module#82dmklee wants to merge 1 commit intoQUVA-Lab:masterfrom
dmklee wants to merge 1 commit intoQUVA-Lab:masterfrom
Conversation
The assertion checks in SequentialModule.add_module assume that the module is
being added to the end of the sequence. However, it calls torch.nn.Module.add_module
which allows for overwriting existing modules by name. So, if one tries to overwrite an
existing module by name, an assertion error is raised. I modified the assertion checks
so that modules can be overwritten so long as they have the correct in_type and out_type
according to the modules before and after them in the sequence.
I encountered this issue when trying to call torch.nn.SyncBatchNorm.convert_sync_batchnorm
on a SequentialModule. With this change, you can sync InnerBatchNorm's across machines during
training since they use torch.nn.BatchNormXd under the hood.
Signed-off-by: David Klee
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.