-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Bug/fix windows npm utf8 issues#926
Open
jj-github-jj wants to merge 3 commits intoPromtEngineer:mainfrom
Open
Conversation
Description
Fixes windows os related error messages on windows resulting from utf-8 issues and not finding the npm on windows system
After these updates, run_system.py works in windows 11
Fixes #(issue number)
Type of Change
- [X ] Bug fix (non-breaking change which fixes an issue)
- New feature (non-breaking change which adds functionality)
- Breaking change (fix or feature that would cause existing functionality to not work as expected)
- Documentation update
- Test improvements
- Code refactoring
- UI/UX improvements
Testing
Test Environment
- Tested with Docker deployment
- Tested with direct Python deployment
- Tested on macOS
- Tested on Linux
- Tested on Windows
Test Cases
- All existing tests pass
- New tests added for new functionality
- Manual testing completed
- System health check passes
# Commands used for testing
python system_health_check.py
python run_system.py --health
# Add any specific test commands here
python system_health_check.py
python run_system.py --health
# Add any specific test commands here
Checklist
Code Quality
- Code follows the project's coding standards
- Self-review of the code completed
- [X ] Code is properly commented
- Type hints added (Python)
- No console.log statements left in production code
Documentation
- Documentation updated (if applicable)
- API documentation updated (if applicable)
- README updated (if applicable)
- CONTRIBUTING.md guidelines followed
Dependencies
- No new dependencies added, or new dependencies are justified
- requirements.txt updated (if applicable)
- package.json updated (if applicable)
Screenshots (if applicable)
Add screenshots to help reviewers understand the changes.
Performance Impact
Describe any performance implications:
- No performance impact
- Performance improved
- Performance may be affected (explain below)
Migration Notes
If this is a breaking change, describe what users need to do:
- No migration needed
- Migration steps documented below
Additional Notes
Any additional information that reviewers should know.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.