-
Notifications
You must be signed in to change notification settings - Fork 9
Open
Open
Is the ProblemDocument class really neessary?#34
Description
Working some more with this and related libraries I'm repeatedly thinking whether the ProblemDocument really needs to be a class?
Wouldn't it be enough to simply define a contract for a problem document and have mapper return plain objects?
interface ProblemDocument extends Record<string, unknown> {
detail?: string;
instance?: string;
status: number;
title: string;
type?: string;
}
class Mapper {
mapError(error): ProblemDocument {
return {
status: 500,
title: 'Something happened'
}
}
}
detail?: string;
instance?: string;
status: number;
title: string;
type?: string;
}
class Mapper {
mapError(error): ProblemDocument {
return {
status: 500,
title: 'Something happened'
}
}
}
This would simplify how extensions are implemented and make it easier to work with derived or decorated mappers
Metadata
Metadata
Assignees
Labels
No labels