-
Notifications
You must be signed in to change notification settings - Fork 72
Define services in config and add Docker workflow#41
Open
iamsilk wants to merge 13 commits intoOpenAttackDefenseTools:masterfrom
Open
Define services in config and add Docker workflow#41iamsilk wants to merge 13 commits intoOpenAttackDefenseTools:masterfrom
iamsilk wants to merge 13 commits intoOpenAttackDefenseTools:masterfrom
Conversation
This PR makes two additions:
- Services are defined via the config instead of code. This works by adding two environment variables:
VM_IPandTULIP_SERVICES_PATH. TheTULIP_SERVICES_PATHvariable specifies the path to a JSON file with the services. - Adds a GitHub workflow to build and publish each Docker image, removing the need to build the images on the deployment machine.
This PR publishes the Docker images to the GitHub Container Registry, not Docker Hub. My use case used GHCR, but feel free to adjust the workflow to your needs.
If merging, make sure to change the image links in the docker-compose.prod.yml file from ghcr.io/iamsilk to ghcr.io/OpenAttackDefenseTools.
Update configurations.py
Contributor
|
This is great, you can make it cleaner by just putting the json data into the .env file: # The services and ports
|
AnuchaRodpha
approved these changes
Nov 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.