-
Notifications
You must be signed in to change notification settings - Fork 25
Merged
Conversation
Collaborator
The PISCES test is currently commented out and is thus not running during CI.
When running locally the mass conservation also fails:
[ Info: Testing PISCES element conservation (C, Fe, P, Si, N)
PISCES: Test Failed at /home/phyto-2/OceanBioME.jl-1/test/test_PISCES.jl:89
Expression: isapprox(total_silicon_tendencies, 0, atol = 10 ^ -30)
Evaluated: isapprox(3.308722450212111e-24, 0; atol = 1.0e-30)
Stacktrace:
[1] macro expansion
@ ~/.julia/juliaup/julia-1.10.10+0.x64.linux.gnu/share/julia/s tdlib/v1.10/Test/src/Test.jl:672 [inlined]
[2] test_PISCES_conservation()
@ Main ~/OceanBioME.jl-1/test/test_PISCES.jl:89
[3] macro expansion
@ ~/OceanBioME.jl-1/test/test_PISCES.jl:174 [inlined]
[4] macro expansion
@ ~/.julia/juliaup/julia-1.10.10+0.x64.linux.gnu/share/julia/s tdlib/v1.10/Test/src/Test.jl:1577 [inlined]
[5] top-level scope
@ ~/OceanBioME.jl-1/test/test_PISCES.jl:173
I have uncommented the PISCES test and increased the Si tolerance to match the nitrogen tendency.
closes #344
Merged
jagoosw
approved these changes
Mar 14, 2026
Collaborator
jagoosw
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for catching!
Collaborator
Author
|
I did a quick sanity check: So it all looks good to me. I don't have permission to merge but I'm happy with it now |
Collaborator
Thank you! I'll merge and add permissions for you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.