-
Notifications
You must be signed in to change notification settings - Fork 10
Conversation
Collaborator
Merge Checklist
Please cross check this list if additions / modifications needs to be done on top of your core changes and tick them off. Reviewer can as well glance through and help the developer if something is missed out.
- Automated Tests (Jasmine integration tests, Unit tests, and/or Performance tests)
- Updated Manual tests / Demo Config
- Documentation (Application guide, Admin guide, Markdown, Readme and/or Wiki)
- Verified that local development environment is working with latest changes (integrated with latest
developbranch) - following best practices in code review doc
csafreen
requested review from
KangJingA,
LSriragavan,
SantanM,
Zhimin-arya,
alicia-koh,
brandantck,
hengxian-jiang,
jerome-ng,
khairul-syazwan,
maggie-li-yd,
p-hoffmann,
satish-a0 and
suwarnoong
as code owners
February 26, 2026 13:45
csafreen
changed the title
Fix issues when database code is same as schema name
Fix DC/DQD when database code is same as schema name
Feb 26, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Updates analytics and flow execution paths to better handle environments where a dataset's databaseCode and schemaName can collide (or where fully-qualified identifiers are required), and adds a guard for missing CDM versions before launching jobs.
Changes:
- Add a CDM-version presence check before creating DQD / Data Characterization flow runs.
- Update analytics-svc CDM version lookup to include
databaseCodeand adjust Data Characterization vocab schema replacement to be database-qualified. - Update Prefect flow plugins / shared utils to allow or use dot-qualified schema identifiers (
db.schema).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| functions/jobplugins/src/services/DqdService.ts | Adds a guard to fail fast when CDM version is missing before launching DQD. |
| functions/jobplugins/src/services/DataCharacterizationService.ts | Adds the same CDM version guard before launching Data Characterization. |
| functions/analytics-svc/src/dao/DBDAO.ts | Changes CDM version query to reference databaseCode.schemaName. |
| functions/analytics-svc/src/api/controllers/dbsvc.ts | Passes databaseCode into getCDMVersion. |
| functions/analytics-svc/src/api/controllers/dataCharacterization.ts | Changes vocab schema replacement to databaseName.vocabSchema. |
| flows/base/dqd_plugin/flow.py | Passes databaseCode.schemaName into the R entrypoint parameters. |
| flows/base/data_characterization_plugin/utils.py | Qualifies TREX cdm_source query with dbdao.database_code. |
| flows/base/data_characterization_plugin/flow.py | Qualifies vocab/cdm schemas with databaseCode. for schema creation and R execution. |
| flows/_shared_flow_utils/create_dataset_tasks.py | Expands schema safety regex to allow dot-qualified identifiers. |
functions/jobplugins/src/services/DataCharacterizationService.ts
Outdated
Show resolved
Hide resolved
alicia-koh
approved these changes
Feb 27, 2026
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
functions/jobplugins/src/services/DataCharacterizationService.ts
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.