-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Open
Conversation
Contributor
This PR corrects misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/Hystrix/actions/runs/5039485122#summary-13642774871
The action reports that the changes in this PR would make it happy: https://github.com/jsoref/Hystrix/actions/runs/5039485673#summary-13642775939
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref
jsoref
commented
May 21, 2023
| ### Version 1.5.8 ([Maven Central](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22c om.netflix.hystrix%22%20AND%20v%3A%221.5.8%22), [Bintray](https://bintray.com/netflixoss/maven/Hystrix/1.5.8 /)) ### | ||
|
|
||
| * [Pull 1419](https://github.com/Netflix/Hystrix/pull/1419) When user has not opted in to letting core/maximum threadpools diverge, ensure dynamic updates to coreSize apply to both | ||
| * [Pull 1419](https://github.com/Netflix/Hystrix/pull/1419) When user has not opted into letting core/maximum threadpools diverge, ensure dynamic updates to coreSize apply to both |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in to -> into changes have been quite controversial.
Happy to drop this.
Some projects don't like changing changelogs...
| * [Pull 1382](https://github.com/Netflix/Hystrix/pull/1382) Bump jmh to 1.15. Thanks @monkey-mas! | ||
| * [Pull 1380](https://github.com/Netflix/Hystrix/pull/1380) Add jmh test for open-circuit case | ||
| * [Pull 1376](https://github.com/Netflix/Hystrix/pull/1376) Clean up documentation around thread keep-alive. Thanks @bitb ! | ||
| * [Pull 1376](https://github.com/Netflix/Hystrix/pull/1376) Clean up documentation around thread keep-alive. Thanks @bltb ! |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notably, the credit here was wrong...
| ### Version 1.3.11 ([Maven Central](http://search.maven.org/#search%7Cga%7C1%7Cg%3A%22c om.netflix.hystrix%22%20AND%20v%3A%221.3.11%22)) ### | ||
|
|
||
| * We'll ignore this release ever happened. Exact same binary as 1.3.10. (It helps to push code to Github before releasing.) | ||
| * We'll ignore this release ever happened. Exact same binary as 1.3.10. (It helps to push code to GitHub before releasing.) |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
brand
| * @throws ClassNotFoundException | ||
| */ | ||
| public Method unbride(final Method bridgeMethod, Class aClass) throws IOException, NoSuchMethodException, ClassNotFoundException { | ||
| public Method unbridge(final Method bridgeMethod, Class aClass) throws IOException, NoSuchMethodException, ClassNotFoundException { |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
notable. API break?
| assertEquals(5L, servoPublisher.getRollingMonitor("timeout", HystrixEventType.TIMEOUT).getValue()); | ||
| assertEquals(1L, servoPublisher.getRollingMonitor("failure", HystrixEventType.FAILURE).getValue()); | ||
| assertEquals(6L, servoPublisher.getRollingMonitor("falback_success", HystrixEventType.FALLBACK_SUCCESS).getValue()); | ||
| assertEquals(6L, servoPublisher.getRollingMonitor("fallback_success", HystrixEventType.FALLBACK_SUCCESS).getValue()); |
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potentially problematic
|
Hao De ,Wo Yi Shou Dao .
|
CloneOfAlex
approved these changes
Apr 9, 2024
CloneOfAlex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely Done
|
Hao De ,Wo Yi Shou Dao .
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.