-
Notifications
You must be signed in to change notification settings - Fork 46
Fix detect_deletions disable gating and harden timeout handling#333
Open
tomerh2001 wants to merge 1 commit intoManiMatter:devfrom
Open
Fix detect_deletions disable gating and harden timeout handling#333tomerh2001 wants to merge 1 commit intoManiMatter:devfrom
tomerh2001 wants to merge 1 commit intoManiMatter:devfrom
Conversation
Summary
- Fix
detect_deletionsgating so disabled jobs do not start folder watchers (main.pynow checks.enabled). - Add
JobParams.__bool__so object truthiness consistently reflects job enabled state. - Add configurable global HTTP timeout via
general.request_timeout(and envREQUEST_TIMEOUT) instead of a hardcoded 15s timeout inmake_request. - Add runtime error boundaries so request failures in ARR/download-client job groups are logged and the main loop keeps running instead of crashing.
- Update docs/example config for
request_timeoutand add regression tests.
Why
- Fixes behavior reported in detect_deletions runs even when explicitly disabled (v2.0.0) #329 (
detect_deletionsruns even when disabled). - Addresses crash-loop behavior from timeout failures in decluttarr crashes on slow server when read times out #317 by making timeout tunable and by preventing one request failure from terminating the full run loop.
Validation
python3 -m pytest -qpython3 -m pylint main.py src/job_manager.py src/utils/common.py src/settings/_general.py src/settings/_jobs.py src/settings/_user_config.py tests/jobs/test_job_manager.py tests/settings/test_general.py tests/settings/test_jobs.py tests/utils/test_common.py
This was referenced Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.