-
Notifications
You must be signed in to change notification settings - Fork 811
Use spawn start method for multiprocessing inside the test to avoid deadlock/timeout#5213
Use spawn start method for multiprocessing inside the test to avoid deadlock/timeout#5213yuxuanzhuang wants to merge 5 commits intodevelopfrom
Conversation
Fixes #5191
Changes made in this Pull Request:
- use a spawn start method inside the test to avoid deadlock
LLM / AI generated code disclosure
LLMs or other AI-powered tools (beyond simple IDE use cases) were used in this contribution: no
PR Checklist
- Issue raised/referenced?
- Tests updated/added?
- Documentation updated/added?
-
package/CHANGELOGfile updated? - Is your name in
package/AUTHORS? (If it is not, add it!) - LLM/AI disclosure was updated.
Developers Certificate of Origin
I certify that I can submit this code contribution as described in the Developer Certificate of Origin, under the MDAnalysis LICENSE.
Documentation preview : https://mdanalysis--5213.org.readthedocs.build/en/5213/
Codecov Report All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5213 +/- ## ======================================== Coverage 93.83% 93.83% ======================================== Files 180 180 Lines 22473 22473 Branches 3189 3189 ======================================== Hits 21088 21088 Misses 923 923 Partials 462 462 View full report in Codecov by Sentry. New features to boost your workflow:
|
77452dc to
81b8ef5
Compare
81b8ef5 to
7e9a99c
Compare
|
Tested twice and passed. |
orbeckst
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd be happy to merge and see if it improves things.
Could you add a comment to the test (along #5191 (comment) ) explaining the changes and referencing issue/PR, just so that future us knows where to look. I might even leave the original code commented out in one case, just to see clearly what the workaround does, given that the current code is probably what most people would use.