-
Notifications
You must be signed in to change notification settings - Fork 501
Draft
Conversation
Member
Reverts #3418, removing the ability to detect overlaps where both axes start overlapping on the same frame. This change broke standing on moving platforms.
Fixes bug introduced in #3158 where jumping didn't work depending on order of super.update() and collide calls.
The reproducing code is a copy of the Jumping snippet but with the input detection before the collide call)
package states;
import flixel.FlxG;
import flixel.FlxSprite;
import flixel.ui.FlxVirtualPad;
class JumpTestState extends flixel.FlxState
{
var sprite:FlxSprite;
var box:FlxSprite;
var pad:FlxVirtualPad;
override function create()
{
super.create();
sprite = new FlxSprite();
sprite.makeGraphic(24, 24);
sprite.x = FlxG.width / 2 - sprite.width / 2;
sprite.acceleration.y = 900;
sprite.maxVelocity.y = 300;
add(sprite);
box = new FlxSprite();
box.makeGraphic(40, 40);
box.x = FlxG.width / 2 - box.width / 2;
box.y = FlxG.height * 0.75 - box.height / 2;
box.immovable = true;
add(box);
pad = new FlxVirtualPad(FlxDPadMode.NONE, FlxActionMode.A);
add(pad);
}
override function update(elapsed:Float)
{
// call super.update first, as it sets touching flags to NONE
super.update(elapsed);
// jump if touching the box, and jump is pressed
if (sprite.wasTouching.down && pad.getButton(A).justPressed)
{
sprite.velocity.y = -300;
}
// If sprite is resting on box it will set its touching to DOWN
FlxG.collide(box, sprite);
}
}
import flixel.FlxG;
import flixel.FlxSprite;
import flixel.ui.FlxVirtualPad;
class JumpTestState extends flixel.FlxState
{
var sprite:FlxSprite;
var box:FlxSprite;
var pad:FlxVirtualPad;
override function create()
{
super.create();
sprite = new FlxSprite();
sprite.makeGraphic(24, 24);
sprite.x = FlxG.width / 2 - sprite.width / 2;
sprite.acceleration.y = 900;
sprite.maxVelocity.y = 300;
add(sprite);
box = new FlxSprite();
box.makeGraphic(40, 40);
box.x = FlxG.width / 2 - box.width / 2;
box.y = FlxG.height * 0.75 - box.height / 2;
box.immovable = true;
add(box);
pad = new FlxVirtualPad(FlxDPadMode.NONE, FlxActionMode.A);
add(pad);
}
override function update(elapsed:Float)
{
// call super.update first, as it sets touching flags to NONE
super.update(elapsed);
// jump if touching the box, and jump is pressed
if (sprite.wasTouching.down && pad.getButton(A).justPressed)
{
sprite.velocity.y = -300;
}
// If sprite is resting on box it will set its touching to DOWN
FlxG.collide(box, sprite);
}
}
Member
Author
|
Turns out 3158 did not introduce a bug, the above test has always been broken. Gonna shelf this open a new PR to revert 3418 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.