-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Open
Conversation
When parsing input03, the parser2 won't report syntax error until it reachs the plus sign.
struct ASTnode *additive_expr(void) {
struct ASTnode *left, *right;
int tokentype;
left = multiplicative_expr();
tokentype = Token.token;
if (tokentype == T_EOF)
return (left);
// Cache the '+' or '-' token type
/** here the actual cached token is int literal '34' **/
while (1) {
// Fetch in the next integer literal
scan(&Token);
/** scan()s plus sign **/
right = multiplicative_expr();
/** primary() reports syntax error since Token is T_PLUS **/
left = mkastnode(arithop(tokentype), left, right, 0);
tokentype = Token.token;
if (tokentype == T_EOF)
break;
}
return (left);
}
struct ASTnode *left, *right;
int tokentype;
left = multiplicative_expr();
tokentype = Token.token;
if (tokentype == T_EOF)
return (left);
// Cache the '+' or '-' token type
/** here the actual cached token is int literal '34' **/
while (1) {
// Fetch in the next integer literal
scan(&Token);
/** scan()s plus sign **/
right = multiplicative_expr();
/** primary() reports syntax error since Token is T_PLUS **/
left = mkastnode(arithop(tokentype), left, right, 0);
tokentype = Token.token;
if (tokentype == T_EOF)
break;
}
return (left);
}
Author
|
After a second thought, I think it may better to fix the parser2 itself, not the test result |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.