-
-
Notifications
You must be signed in to change notification settings - Fork 333
Explicitly catch the InvalidGitRepositoryError when trying to get the repo information.#276
Open
sww wants to merge 1 commit intoDerwenAI:mainfrom
Open
Explicitly catch the InvalidGitRepositoryError when trying to get the repo information.#276sww wants to merge 1 commit intoDerwenAI:mainfrom
sww wants to merge 1 commit intoDerwenAI:mainfrom
Conversation
If pytextrank is installed via pip, importing pytextrank prints out the root directory where it's installed.
Steps To Reproduce
With Docker using the python:3.12 image, run:
$ pip install pytextrank
$ python -c "import pytextrank"
/usr/local/lib/python3.12/site-packages
$ pip freeze | grep pytextrank
pytextrank==3.3.0
Discussion
The code
pytextrank/pytextrank/version.py
Lines 21 to 28 in 5a92184
| try: | |
| repo_path: pathlib.Path = pathlib.Path(dirname(abspath(__file__))) | |
| repo: Repo = Repo(repo_path.parents[0]) | |
| REPO_HASH = str(repo.head.commit) | |
| REPO_TAGS = repo.tags | |
| except Exception as ex: # pylint: disable=W0703 | |
| print(ex) |
InvalidGitRepositoryError exception arguments, which is just a path.
By explicitly catching that exception, it should no longer print out some unnecessary information. This PR will still raise an other unexpected exceptions, though.
...o information.
Before, when importing pytextrank installed via pip, it would print the path
to the library.
Before, when importing pytextrank installed via pip, it would print the path
to the library.
sww
changed the title
Explicitly catch the InvalidGitRepositoryError when trying to the repo information.
Explicitly catch the InvalidGitRepositoryError when trying to get the repo information.
Oct 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.