-
-
Notifications
You must be signed in to change notification settings - Fork 11
Open
Conversation
Contributor
|
FasterSpeeding
commented
Aug 15, 2023
| raise | ||
| except Exception as exc: | ||
| self._call_loaders(module_path, old_loaders) | ||
| modules_dict.pop(module_path) |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
failed module load could have a variant with a field which indicates whether it reverted or not
FasterSpeeding
commented
Aug 15, 2023
CHANGELOG.md
Outdated
| - [BasicLocaliser.set_variants][tanjun.dependencies.BasicLocaliser.set_variants] | ||
| now tries to normalise the locale keys of variants passed as keyword arguments | ||
| to match the [hikari.Locale][hikari.locales.Locale] values. | ||
| - The hot-reloader no-longer reverts to a module's old components loaded after |
Collaborator
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both reloader and the reload method*
FasterSpeeding
force-pushed
the
bugfix/reloading
branch
from
August 28, 2023 18:44
79c572c to
ee8d1bd
Compare
FasterSpeeding
force-pushed
the
bugfix/reloading
branch
from
August 28, 2023 18:56
ee8d1bd to
faceed2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.