Dark Mode

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Permission normalisation#534

Draft
FasterSpeeding wants to merge 1 commit intomasterfrom
task/implicit-perm-denies
Draft

Permission normalisation#534
FasterSpeeding wants to merge 1 commit intomasterfrom
task/implicit-perm-denies

Conversation

Copy link
Collaborator

FasterSpeeding commented Oct 31, 2022

Summary

Checklist

  • I have run nox and all the pipelines have passed.
  • I have made unittests according to the code I have added/modified/deleted.

Related issues

FasterSpeeding changed the title Initial attempt at normalising perms Permission normalisation Oct 31, 2022
| hikari.Permissions.USE_EXTERNAL_STICKERS
| hikari.Permissions.CREATE_PUBLIC_THREADS
| hikari.Permissions.MODERATE_MEMBERS
| ~_CHANNEL_SEND_PERMS
Copy link
Collaborator Author

FasterSpeeding Oct 31, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the best way to do this? (| ~)

hikari.ChannelType.GUILD_PRIVATE_THREAD,
)
)
_MOVABLE_CHANNEL_TYPES = frozenset(
Copy link
Collaborator Author

FasterSpeeding Nov 1, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better name and document what all these constants are

Base automatically changed from task/hikari-new-release to master November 8, 2022 06:17
FasterSpeeding force-pushed the task/implicit-perm-denies branch from 798e9ac to bcd6f7d Compare November 8, 2022 06:33
FasterSpeeding force-pushed the task/implicit-perm-denies branch 2 times, most recently from f1dff5b to 0d2067f Compare November 22, 2022 12:44
Copy link
Contributor

github-actions bot commented Nov 22, 2022 *
edited
Loading

PR Preview Action ddfa7dc4b5f8fa02675fe5da02ae15c9722367f0
Deployed preview to https://FasterSpeeding.github.io/Tanjun/pr-preview/pr-534/
on branch docs at 2023-01-31 06:58 UTC

FasterSpeeding force-pushed the task/implicit-perm-denies branch 3 times, most recently from 7afadb1 to 6f8ff0f Compare December 1, 2022 03:47
FasterSpeeding force-pushed the task/implicit-perm-denies branch from 6f8ff0f to ad0c43e Compare December 8, 2022 19:18
FasterSpeeding force-pushed the task/implicit-perm-denies branch from ad0c43e to 0b03ea0 Compare December 30, 2022 11:29
FasterSpeeding force-pushed the task/implicit-perm-denies branch from 0b03ea0 to e20c4f5 Compare January 24, 2023 08:53
FasterSpeeding force-pushed the task/implicit-perm-denies branch from e20c4f5 to 94e0ebc Compare January 31, 2023 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant